Rest* to Http* renaming - #228
Merged
Merged
Conversation
PDR-091d renames the client class so it states what it is rather than repeating the vendor name. This is the last public-API change before the 2.0.0 integration branch merges, and the only one that touches consumers' type hints and DI bindings. src/AblyRest.php moves to src/PubSubHttpClient.php to preserve the PSR-4 file/class mapping, and the two test classes follow; every use statement, type hint and docblock in src/ and tests/ is updated, so Server::createHttpClient() now returns \Ably\PubSub\PubSubHttpClient. The rest-prefixed ClientOptions keys are deliberately left alone: restHost and idempotentRestPublishing are cross-SDK spec names (RSC11, TO3n), and renaming them would leave PHP the only SDK spelling them differently. CHANGELOG gains a breaking-change entry; UPDATING.md gains a mapping row and loses its draft banner now the naming is settled. plan.md goes too: it sequenced the split work, which this commit completes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 49 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (34)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
maratal
approved these changes
Sep 21, 2026
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The rename is consistently reflected across the reviewed source, tests, and documentation with no unresolved blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Renames the core AblyRest client to PubSubHttpClient across the SDK.
Changes:
- Updated client implementations, type hints, factories, and error messages.
- Updated tests and client references.
- Updated migration documentation and changelog; removed
plan.md.
| File | Description |
|---|---|
UPDATING.md |
Documents the client rename. |
tests/TypesTest.php |
Updates the client import. |
tests/TokenTest.php |
Updates client construction. |
tests/PushDeviceRegistrationsTest.php |
Updates client usage. |
tests/PushChannelSubscriptionsTest.php |
Updates client usage. |
tests/PushAdminTest.php |
Updates client usage. |
tests/PubSubHttpClientTest.php |
Renames the test class and usages. |
tests/PubSubHttpClientRequestTest.php |
Renames the request test and usages. |
tests/PresenceTest.php |
Updates client usage. |
tests/LogTest.php |
Updates client usage. |
tests/HttpTest.php |
Updates client usage and documentation. |
tests/factories/TestApp.php |
Updates the client import. |
tests/ClientIdTest.php |
Updates client construction. |
tests/ChannelStatusTest.php |
Updates client usage. |
tests/ChannelMessagesTest.php |
Updates client usage. |
tests/ChannelIdempotentTest.php |
Updates client usage. |
tests/ChannelHistoryTest.php |
Updates client usage. |
tests/AuthTest.php |
Updates client usage. |
tests/AppStatsTest.php |
Updates client usage. |
src/Server.php |
Returns the renamed client. |
src/PushDeviceRegistrations.php |
Updates the client type hint. |
src/PushChannelSubscriptions.php |
Updates the client type hint. |
src/PushAdmin.php |
Updates the client type hint. |
src/Push.php |
Updates the client type hint. |
src/PubSubHttpClient.php |
Renames the client implementation and references. |
src/Presence.php |
Updates the client type hint. |
src/Models/PaginatedResult.php |
Updates the client type hint. |
src/Models/HttpPaginatedResponse.php |
Updates the client type hint and documentation. |
src/Http.php |
Updates the client import. |
src/Channels.php |
Updates the client type hint. |
src/Channel.php |
Updates the client type hint. |
src/Auth.php |
Updates the client type hint and error message. |
plan.md |
Removes the completed implementation plan. |
CHANGELOG.md |
Records the breaking rename. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-side packages already describe the stateless client in HTTP
terms (
createHttpClient()) while the corestill called it Rest. Align the core's naming with that terminology.