Repository navigation
Conversation
Signed-off-by: mercael <mercael91@gmail.com>
Signed-off-by: mercael <mercael91@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Both files reported the actual value by calling the learner function again inside the message. CONTRIBUTING.md asks for the actual value where it is cheap but never a re-call, so the call is bound once and the message reads that binding instead. The three long lines are also wrapped to stay inside the 80-column limit.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #95
What changed
Both files listed in the issue now report actionable messages on the 5 bare
assertions, and nothing else in the curriculum is touched:
checks/testing/testing8.py— the three spot-check assertions name theexpected celsius value and the returned one.
checks/testing/testing10.py— the empty-list and negative-list assertionsname the expected sum and the returned one.
Style
CONTRIBUTING.md asks for the actual value "where it is cheap, but never
re-call the learner's function inside the message". Each call is bound once
(
celsius_32 = fahrenheit_to_celsius(32)) and the message reads that binding,so the learner's function runs exactly as often as before. Every added line
stays inside the 80-column limit (the one 85-char line in
testing10.py:5isunchanged from
dev).Assertion predicates, ordering, side effects and the success prints are
unchanged (
testing8 ok/testing10 ok).Verification
python -m pytest tests/integration/test_solution_verify.py -qpasses: allreference answers verify against both checks.
e.g.
sum_list([]) should be 0, got 42andfahrenheit_to_celsius(32) should be 0.0, got 999.0.