Skip to content

Fix #90 - #157

Closed
mercael91 wants to merge 5 commits into
abhiksark:devfrom
mercael91:fix/issue-90
Closed

mercael91 wants to merge 5 commits into
abhiksark:devfrom
mercael91:fix/issue-90

Conversation

@mercael91

@mercael91 mercael91 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Closes #90

Adds actionable messages to all 14 bare assertions listed in the issue, across all five in-scope check files:

  • checks/generators/generators1.py: 3
  • checks/generators/generators3.py: 2
  • checks/generators/generators6.py: 2
  • checks/generators/generators7.py: 2
  • checks/generators/generators8.py: 5

Each message states the expected value and, where it is readily available, the actual value. Assertion predicates, ordering, side effects and success prints are unchanged, and no check outside the listed files is touched. A regression test (tests/test_generators_assertion_messages.py) asserts that those five check files contain zero bare assertions. Python 3.9 compatible.

… test

Signed-off-by: mercael <mercael91@gmail.com>
… test

Signed-off-by: mercael <mercael91@gmail.com>
… test

Signed-off-by: mercael <mercael91@gmail.com>
… test

Signed-off-by: mercael <mercael91@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 71571ca6-b084-44e3-9213-112b34a447b7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mercael91

Copy link
Copy Markdown
Contributor Author

Closing due to inactivity. Happy to reopen if there's interest.

@mercael91 mercael91 closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant