Repository navigation
Conversation
Implements the policy proposed in abhiksark#133, scoped to what it asks for: * checks/**/*.py ignores F821 only — those undefined names come from the learner namespace the runner resolves at runtime, so they are expected rather than defects; * ruff moves into the dev extra so the config is reachable from pip install -e .[dev]. No global select/ignore block is added: Ruff stays on its defaults so the checks/ exception is the only new policy, and the remaining violations stay open for their own pass.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing due to inactivity. Happy to reopen if there's interest. |
1 participant
Implements the policy proposed in #133, scoped to what it asks for:
[tool.ruff.lint.per-file-ignores]with"checks/**/*.py" = ["F821"]— those undefined names come from the learner namespace the runner resolves at runtime, so they are expected rather than defects;ruff>=0.6.0in thedevextra, so the config is reachable from a plainpip install -e .[dev].No global
select/ignoreblock is added: Ruff stays on its defaults, so thechecks/exception is the only new policy and the rest stays open for its own pass.Measured with ruff 0.16.9 on this checkout: F821 drops from 2267 findings to 1079, i.e. the
checks/tree accounts for ~1188 of them. The remaining ~1079 are inexercises/andsolutions/(same learner-stub reason) and are deliberately left alone. E501 and the other ~212 violations are untouched — 1244 findings before and after.