Repository navigation
Matching functions for PlayerSaveStruct_G - #3
Merged
Merged
Conversation
…lth, IncreaseHealth, IncreaseHealthMax, DecreaseHealth
0x5abe
self-requested a review
September 9, 2026 23:48
0x5abe
requested changes
Sep 9, 2026
0x5abe
left a comment
0x5abe
left a comment
Member
There was a problem hiding this comment.
The only change this needs is for the functions to be placed in the correct order in ScriptManager_G.cpp. In objdiff you can see the order of the functions and these go below PlayerSaveStruct_G::Reset() in a different order than the one they're currently in.
0x5abe
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DecreaseHealth returns a boolean for an amazing reason.