Skip to content

Refactor tag controls in event.php - #5194

Open
IgorA100 wants to merge 4 commits into
ZoneMinder:masterfrom
IgorA100:patch-964748
Open

IgorA100 wants to merge 4 commits into
ZoneMinder:masterfrom
IgorA100:patch-964748

Conversation

@IgorA100

@IgorA100 IgorA100 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Refactored tag controls for improved structure and functionality.

Refactored tag controls for improved structure and functionality.
Added styles for tag controls and dropdowns.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Existing tags are displayed in reverse response order due to prepending each element.

1 open finding
What changed in this PR

Refactors event tag markup and styling to separate displayed tags from input/navigation controls.

Changes:

  • Adds dedicated tag and control wrappers.
  • Updates tag insertion and responsive flex styling.
File Description
event.js Inserts tags into the new container.
event.php Restructures tag controls.
event.css Styles the new flex layout.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread web/skins/classic/views/js/event.js Outdated
@Simpler1

Simpler1 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

This is absolutely horrible for both standard and narrow displays.

@IgorA100

IgorA100 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

This is absolutely horrible for both standard and narrow displays.

Please provide a screenshot and a description of exactly what you don't like. It's possible I overlooked some nuance.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@IgorA100

IgorA100 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

It should be like this:
I don't think there's anything terrible about it.
Or am I wrong?
01
02
03
04
05

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants