Skip to content

fix: emulate pipe2 with pipe + fcntl on platforms without it #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connortechnology merged 1 commit into from
Jul 22, 2026
Merged

fix: emulate pipe2 with pipe + fcntl on platforms without it #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/net/Pipe.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
#include <random>
#include <string>
#include <array>
#if !defined(WIN32) && !defined(_WIN32)
#include <fcntl.h>
#include <unistd.h>
#endif

using namespace xop;

Expand Down Expand Up @@ -56,10 +60,22 @@ bool Pipe::Create()

SocketUtil::SetNonBlock(pipe_fd_[0]);
SocketUtil::SetNonBlock(pipe_fd_[1]);
#else /* Not Windows */
#elif defined(__linux) || defined(__linux__)
if (pipe2(pipe_fd_, O_NONBLOCK | O_CLOEXEC) < 0) {
return false;
}
#else /* macOS/BSD: no pipe2(), emulate with pipe() + fcntl() */
if (pipe(pipe_fd_) < 0) {
return false;
}
for (int i = 0; i < 2; i++) {
if (fcntl(pipe_fd_[i], F_SETFL, fcntl(pipe_fd_[i], F_GETFL) | O_NONBLOCK) < 0 ||
fcntl(pipe_fd_[i], F_SETFD, FD_CLOEXEC) < 0) {
::close(pipe_fd_[0]);
::close(pipe_fd_[1]);
return false;
}
}
#endif
return true;
}
Expand Down
Loading