Native CRT video v2: DDR contract, analog video settings, calibration screen

[wizzomafizzo]

Summary

Adopts the Menu_MiSTer fork's v2 native video contract and moves CRT ownership into the launcher, now that Main_MiSTer has dropped its OSD video pages and status[9] CRT bit. Pairs with the Menu fork branch fix/native-video-centering and the corresponding Main_MiSTer changes - all three must be deployed together for the CRT path (HDMI is unaffected; mismatched combos fail obviously, by design).

Writer (DDR contract v2)

• 3 MB region at 0x3A000000; word0 (frame_counter << 2) | active_buffer, word1 magic 0x5A50 / h_offset / v_offset / mode; buffers at +0x1000 / +0x180000.
• fb0 geometry selects the mode: 352x240 NTSC (0), 720x480i (1), 352x288 PAL (2). Anything else - including an old host's 320x240 - self-disables the writer with a logged warning.
• word1 is written before the first word0 publish; stop zeroes word0 then word1. Bit layout locked by compile-time static_asserts.

Settings + calibration

• MiSTer-only Analog video section on the Display page: CRT mode toggle (always shown so HDMI users can switch in), Video standard (NTSC/PAL), Screen position.
• The toggle is confirm-gated: confirming writes config/zaparoo_launcher_crt.bin and exits with code 42 so Main respawns the frontend under the new mode.
• Calibration screen: test pattern at true framebuffer pixels (edge frame, action/title-safe outlines, crosshatch); arrows nudge centering live via word1; values persist on exit only (no SD churn from hold-repeat).
• New Browse.CrtVideo singleton owns standard + offsets, persisted via state.toml with the frontend.toml mirror.

Safe area

• scene shrinks 5% per side in CRT mode only; Sizing bindings propagate it everywhere with no per-screen changes. Background and screensaver overscan to the true edge.

Fixes

• exit-1000 restart previously execvp'd the filtered argv, silently dropping --crt on any restart-applied setting change in CRT mode. Restart now reuses the unfiltered argv.

Deliberately not in this PR

• 480i is fully plumbed (writer mode 1, crt_video_standard = "480i" accepted in frontend.toml for smoke tests) but not offered in the picker - the UI flicker-discipline pass for interlace comes separately.
• No migration of old zaparoo_video_offsets.bin values; offsets start at 0.

Testing

• just lint, just test (432 tests), just arm32 all green; 16 translation catalogs refreshed.
• Verified on hardware (MiSTer + CRT): NTSC picture with stride-1408 fb, live offset nudges, exit-42 toggle round trip, writer publishes correctly (control words + pixels confirmed via devmem).
• Note for testers: Main only loads menu_zaparoo.rbf into the FPGA at its own startup - reboot after copying a new core or you'll see the noise pattern.

This PR stays in draft while testers run it; it will be rebased onto main periodically.

Summary by CodeRabbit

Release Notes

• New Features
  • Added a CRT calibration overlay with H/V offset readout and Save/Cancel.
  • Added native CRT video controls: standard selection (NTSC/PAL), CRT enable/disable, and live H/V offset adjustment with commit/apply.
  • Added MiSTer-only CRT analog controls and writing of the CRT enable configuration.
• Improvements
  • Persist and clamp CRT settings/offsets, apply standard-based sizing, preserve --crt on restart, and refine CRT safe-area/overscan rendering.
  • Enhanced native CRT forced-path behavior and live offset updates (where supported).
• Tests
  • Added/expanded CRT settings and normalization/validation coverage.
• Documentation
  • Updated translations for the new CRT calibration and settings UI.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds native CRT path calibration for MiSTer: new CRT fields in config/persist schemas, a CrtVideoRust cxx-qt model exposing video standard and centering offsets to QML, a v2 DDR native-video writer with dynamic mode selection and runtime offset adjustment, QML settings controls and a full-frame calibration overlay modal, restart argument preservation for --crt, and translation catalog updates across 17 languages.

Changes

Native CRT Path Calibration

Layer / File(s)	Summary
CRT config/persist schema and utility functions rust/zaparoo-core/src/config.rs, rust/zaparoo-core/src/persist.rs	SettingsConfig, SettingsMirror, RawSettings, and SettingsState gain crt_video_standard, crt_h_offset, crt_v_offset fields with serde defaults; new public helpers normalize_crt_video_standard, crt_video_dimensions, crt_mode_id, clamp_crt_offsets, and offset-range constants are added with full unit test coverage.
Settings merge and mirror-to-config for CRT rust/frontend/src/models/settings.rs	merge_settings clamps CRT offsets from config with snapshot fallback and normalizes crt_video_standard; persist_settings and mirror_settings_to_config are widened to pub(super) and the mirror gains CRT fields.
CrtVideoRust Qt model and QML bridge rust/frontend/src/models/crt_video.rs, rust/frontend/src/models/mod.rs, rust/frontend/build.rs	New CrtVideoRust/CrtVideo cxx-qt singleton exposes crt_enabled, available_video_standards, current_video_standard, h_offset, v_offset as QML properties and provides set_video_standard, set_offsets, commit_offsets, write_crt_enable_file invokables; MiSTer build calls zaparoo_native_video_set_offsets via unsafe FFI on offset changes.
Rust FFI offset getters and init path rust/frontend/src/lib.rs	OnceLock statics cache clamped CRT offsets; zaparoo_rust_crt_h_offset/zaparoo_rust_crt_v_offset exported as #[no_mangle] extern "C"; crt_native_path_forced init branch derives dimensions from the config video standard and caches offsets.
MiSTer sysfs framebuffer mode setter rust/frontend/src/mister_runtime.rs	The run_vmode_with_format call in the CRT branch is replaced by set_fb_mode_sysfs, a new helper that reads /sys/module/MiSTer_fb/parameters/mode, skips writing when unchanged, and logs results.
Native video writer v2 DDR contract src/app/native_video_writer.h, src/app/native_video_writer.cpp	Replaces fixed 320×240 single-word DDR with v2 two-word (g_word0/g_word1) multi-mode geometry (352×240, 720×480, 352×288); adds packNativeVideoWord1 with static_assert; validates framebuffer at init; initializes from Rust-provided offsets; publishes frames via slot-flip with seq_cst fence; adds setNativeVideoOffsets/zaparoo_native_video_set_offsets with no-op stubs for unsupported builds.
Restart argv preservation for --crt src/app/main.cpp	ParsedArguments gains originalArgv preserving the unfiltered argument list; execvp on restart uses originalArgv so --crt survives the restart cycle.
CrtCalibrationModal QML component src/ui/components/CrtCalibrationModal.qml, src/ui/components/CMakeLists.txt	New full-frame calibration overlay renders crosshatch grid, edge frame, and action-safe/title-safe rectangles; handleAction nudges Browse.CrtVideo offsets for directional inputs and commits/closes on accept/cancel; registered in the Zaparoo.Ui QML module.
SettingsScreen CRT controls src/ui/screens/SettingsScreen.qml	MiSTer-only "Analog video" section adds crtEnabled toggle, crtVideoStandard picker, and crtCalibration action row; wires all three into _cycleFocused, handleAction, fieldCommit, and onClicked via new _requestCrtEnabled, _videoStandardList, _videoStandardDisplay helpers.
Main.qml and MainLayout.qml CRT modal orchestration src/ui/app/Main.qml, src/ui/app/MainLayout.qml	Main.qml stages CRT toggle/standard changes through confirmPendingRestart (writes enable file, exits 42) and adds openCrtCalibrationModal/closeCrtCalibrationModal lifecycle functions with global input dispatch. MainLayout.qml mounts the crtCalibrationModalLoader, computes safe-area insets, applies full-bleed background margins, and adds crtScrimBackstop edge strips for overscan modal scrim coverage.
Translation catalog updates (17 languages) src/ui/translations/frontend_*.ts	All 17 language TS files add the CrtCalibrationModal context, update CoreStatusPill indexing/scraping strings to %1/%2 short forms, replace "Settings" with "Settings & Utilities" in HubScreen, and resynchronize Main/MainLayout/SettingsScreen source locations including CRT video standard option strings.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant SettingsScreen
  participant MainQML as Main.qml
  participant CrtVideo as Browse.CrtVideo (Rust)
  participant NativeWriter as zaparoo_native_video_set_offsets
  participant Process as execvp (restart)

  rect rgba(70, 130, 180, 0.5)
    Note over User, Process: CRT Enable Toggle Flow
    User->>SettingsScreen: toggle crtEnabled
    SettingsScreen->>MainQML: requestAccept("crtEnable"/"crtDisable")
    MainQML->>MainQML: stageCrtToggle(enable) → open restartConfirm modal
    User->>MainQML: confirm
    MainQML->>CrtVideo: write_crt_enable_file(enabled)
    MainQML->>Process: Qt.exit(42) → execvp(originalArgv)
  end

  rect rgba(60, 179, 113, 0.5)
    Note over User, NativeWriter: CRT Calibration Flow
    User->>SettingsScreen: activate crtCalibration row
    SettingsScreen->>MainQML: requestAccept("crtCalibration")
    MainQML->>MainQML: openCrtCalibrationModal()
    User->>MainQML: directional input
    MainQML->>CrtVideo: set_offsets(h, v)
    CrtVideo->>NativeWriter: zaparoo_native_video_set_offsets(h, v) [MiSTer FFI]
    User->>MainQML: accept/cancel
    CrtVideo->>CrtVideo: commit_offsets() → persist to config
    MainQML->>MainQML: closeCrtCalibrationModal()
  end

Loading

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Possibly related PRs

• ZaparooProject/zaparoo-frontend#191: Both PRs modify frontend_eu.ts; this PR extends the Basque catalog with the new CrtCalibrationModal context and CRT settings strings that the referenced PR initially established.
• ZaparooProject/zaparoo-frontend#205: Both PRs extend the same settings persistence infrastructure (settings.rs mirror_settings_to_config/merge_settings, config.rs SettingsConfig/SettingsMirror) and update translation catalogs for UI menu reorganization.

Poem

🐇 Hop! The pixels line up true,
Crosshatch grids of orange hue,
H and V offsets saved with care,
MiSTer CRT, crisp and fair!
Press any button — the rabbit's done,
Analog video, perfectly spun. 📺

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: implementing native CRT video v2 with DDR contract, analog video settings, and calibration screen functionality.
Description check	✅ Passed	The description is comprehensive and follows the template with a clear summary, motivation context, detailed testing results, and checklist items completed. All major sections are addressed and the explanation is thorough.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch crt-native-video-v2

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Biome (2.5.0)

src/ui/translations/frontend_ar.ts

File contains syntax errors that prevent linting: Line 1: Expected a type but instead found '?'.; Line 1: expected : but instead found version; Line 1: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 1: Expected an expression for the left hand side of the > operator.; Line 2: Expected a type but instead found '!'.; Line 2: expected : but instead found TS; Line 3: expected > but instead found version; Line 2: Invalid assignment to TS> <TS version; Line 3: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 3: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 5: unterminated regex literal; Line 7: expected > but instead found filename; Line 3: Invalid assignment to "en"> <context> <name>AboutScreen</name> <message> <location filename; Line 7: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 7: Expected an ex

... [truncated 171216 characters] ...

ne 1551: unterminated regex literal; Line 1552: unterminated regex literal; Line 1553: unterminated regex literal; Line 1555: unterminated regex literal; Line 1557: expected > but instead found filename; Line 1551: Invalid assignment to `"unfinished">



TopStatusStrip
; Line 1557: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 1557: Expected an expression but instead found '>'.; Line 1558: Expected an expression but instead found '%'.; Line 1558: unterminated regex literal; Line 1559: Expected an expression but instead found '%'.; Line 1559: unterminated regex literal; Line 1560: unterminated regex literal; Line 1561: unterminated regex literal; Line 1562: unterminated regex literal

src/ui/translations/frontend_de.ts

File contains syntax errors that prevent linting: Line 1: Expected a type but instead found '?'.; Line 1: expected : but instead found version; Line 1: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 1: Expected an expression for the left hand side of the > operator.; Line 2: Expected a type but instead found '!'.; Line 2: expected : but instead found TS; Line 3: expected > but instead found version; Line 2: Invalid assignment to TS> <TS version; Line 3: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 3: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 5: unterminated regex literal; Line 7: expected > but instead found filename; Line 3: Invalid assignment to "en"> <context> <name>AboutScreen</name> <message> <location filename; Line 7: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 7: Expected an ex

... [truncated 160241 characters] ...

ne 1551: unterminated regex literal; Line 1552: unterminated regex literal; Line 1553: unterminated regex literal; Line 1555: unterminated regex literal; Line 1557: expected > but instead found filename; Line 1551: Invalid assignment to `"unfinished">



TopStatusStrip
; Line 1557: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 1557: Expected an expression but instead found '>'.; Line 1558: Expected an expression but instead found '%'.; Line 1558: unterminated regex literal; Line 1559: Expected an expression but instead found '%'.; Line 1559: unterminated regex literal; Line 1560: unterminated regex literal; Line 1561: unterminated regex literal; Line 1562: unterminated regex literal

src/ui/translations/frontend_hi.ts

File contains syntax errors that prevent linting: Line 1: Expected a type but instead found '?'.; Line 1: expected : but instead found version; Line 1: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 1: Expected an expression for the left hand side of the > operator.; Line 2: Expected a type but instead found '!'.; Line 2: expected : but instead found TS; Line 3: expected > but instead found version; Line 2: Invalid assignment to TS> <TS version; Line 3: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 3: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 5: unterminated regex literal; Line 7: expected > but instead found filename; Line 3: Invalid assignment to "en"> <context> <name>AboutScreen</name> <message> <location filename; Line 7: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 7: Expected an ex

... [truncated 176507 characters] ...

ne 1551: unterminated regex literal; Line 1552: unterminated regex literal; Line 1553: unterminated regex literal; Line 1555: unterminated regex literal; Line 1557: expected > but instead found filename; Line 1551: Invalid assignment to `"unfinished">



TopStatusStrip
; Line 1557: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 1557: Expected an expression but instead found '>'.; Line 1558: Expected an expression but instead found '%'.; Line 1558: unterminated regex literal; Line 1559: Expected an expression but instead found '%'.; Line 1559: unterminated regex literal; Line 1560: unterminated regex literal; Line 1561: unterminated regex literal; Line 1562: unterminated regex literal

• 11 others

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[wizzomafizzo]

Attached are the menu and main builds that work with this.

CRT-mode-v2-stuff.zip

ZaparooProject/Menu_MiSTer#4

ZaparooProject/Main_MiSTer#8

And this is the overall plan: https://github.com/ZaparooProject/Menu_MiSTer/blob/b0fe65a4de6ba3d0f5390bf6af1dcb9edb405928/docs/native-video-plan.md

I've purposely deferred the 480i stuff since I figured this PR will be open for discussion for a while and I don't want merging to be too hard, but the plumbing should be there.

In a nutshell:

• In CRT mode we adopt a standard size safe area around the edges.
• The menu core does a "standard broadcast" signal so it goes over the edge for everyone.
• We add PAL and initial stuff for 480i.
• All controls are moved out of the OSD and into the Frontend settings.
• Frontend is responsible for sending settings via the DDR payload.

Looks great for me so far!!! Very nice. It covers my whole screen now and I can adjust it dead centre.

[wizzomafizzo]

@asturur

[wizzomafizzo]

@theypsilon you might also be interested!

[wizzomafizzo]

MiSTer_Zaparoo.zip

Main with fixed PAL mode switch and added CRT mode toggle back to OSD

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/ui/app/MainLayout.qml`:
- Line 95: The CRT calibration modal property crtCalibrationModalRequested does
not have a corresponding help-bar mapping, causing helpEntries to fall through
to the active-screen branch instead of displaying appropriate help actions for
the modal state. Add a help-bar mapping condition that checks
crtCalibrationModalRequested alongside the modal state checks in the helpEntries
logic (around lines 287 and 1459-1470) to ensure that when the calibration modal
is open, the help bar advertises Settings actions instead of falling back to the
active-screen branch behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d9c2b35-ae99-4dbb-a267-fbcd693bd855

📥 Commits

Reviewing files that changed from the base of the PR and between bc1ecf9 and 43b7277.

📒 Files selected for processing (32)

• rust/frontend/build.rs
• rust/frontend/src/lib.rs
• rust/frontend/src/mister_runtime.rs
• rust/frontend/src/models/crt_video.rs
• rust/frontend/src/models/mod.rs
• rust/frontend/src/models/settings.rs
• rust/zaparoo-core/src/config.rs
• rust/zaparoo-core/src/persist.rs
• src/app/main.cpp
• src/app/native_video_writer.cpp
• src/app/native_video_writer.h
• src/ui/app/Main.qml
• src/ui/app/MainLayout.qml
• src/ui/components/CMakeLists.txt
• src/ui/components/CrtCalibrationModal.qml
• src/ui/screens/SettingsScreen.qml
• src/ui/translations/frontend_ar.ts
• src/ui/translations/frontend_de.ts
• src/ui/translations/frontend_el.ts
• src/ui/translations/frontend_en.ts
• src/ui/translations/frontend_es.ts
• src/ui/translations/frontend_eu.ts
• src/ui/translations/frontend_he.ts
• src/ui/translations/frontend_hi.ts
• src/ui/translations/frontend_it.ts
• src/ui/translations/frontend_ja.ts
• src/ui/translations/frontend_ko.ts
• src/ui/translations/frontend_nl.ts
• src/ui/translations/frontend_ro.ts
• src/ui/translations/frontend_sk.ts
• src/ui/translations/frontend_uk.ts
• src/ui/translations/frontend_zh_CN.ts

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/ui/translations/frontend_eu.ts (1)

203-205: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix brand typo in welcome string translation.

Line 204 uses “Zaparro Frontend-era”, but the product name is “Zaparoo”. Please correct the translated brand spelling to avoid user-facing inconsistency.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/ui/translations/frontend_eu.ts` around lines 203 - 205, The translation
value for the source string "Welcome to Zaparoo Frontend" contains a typo where
the product name is misspelled as "Zaparro Frontend-era" instead of "Zaparoo
Frontend-era". Correct the translation element to use the proper product name
"Zaparoo" in the Basque translation to maintain brand consistency across the
user interface.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@src/ui/translations/frontend_eu.ts`:
- Around line 203-205: The translation value for the source string "Welcome to
Zaparoo Frontend" contains a typo where the product name is misspelled as
"Zaparro Frontend-era" instead of "Zaparoo Frontend-era". Correct the
translation element to use the proper product name "Zaparoo" in the Basque
translation to maintain brand consistency across the user interface.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 63e4c3d6-5667-4e81-ba2f-0729b80fd3f9

📥 Commits

Reviewing files that changed from the base of the PR and between 43b7277 and ad63174.

📒 Files selected for processing (17)

• src/ui/app/MainLayout.qml
• src/ui/translations/frontend_ar.ts
• src/ui/translations/frontend_de.ts
• src/ui/translations/frontend_el.ts
• src/ui/translations/frontend_en.ts
• src/ui/translations/frontend_es.ts
• src/ui/translations/frontend_eu.ts
• src/ui/translations/frontend_he.ts
• src/ui/translations/frontend_hi.ts
• src/ui/translations/frontend_it.ts
• src/ui/translations/frontend_ja.ts
• src/ui/translations/frontend_ko.ts
• src/ui/translations/frontend_nl.ts
• src/ui/translations/frontend_ro.ts
• src/ui/translations/frontend_sk.ts
• src/ui/translations/frontend_uk.ts
• src/ui/translations/frontend_zh_CN.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• src/ui/app/MainLayout.qml

[coderabbitai]

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

src/ui/translations/frontend_ar.ts (1)

33-35: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Keep the legal notice faithful to the source.

The Arabic text adds “or redistribution,” which changes the license terms beyond the English source. Please remove that extra restriction in both places.

Suggested fix

-        <translation>المصدر متاح بموجب ترخيص PolyForm Noncommercial 1.0.0. مجاني للاستخدام الشخصي وغير التجاري. يتطلب الاستخدام التجاري أو إعادة التوزيع ترخيصًا منفصلًا.</translation>
+        <translation>المصدر متاح بموجب ترخيص PolyForm Noncommercial 1.0.0. مجاني للاستخدام الشخصي وغير التجاري. يتطلب الاستخدام التجاري ترخيصًا منفصلًا.</translation>

Also applies to: 213-215

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/ui/translations/frontend_ar.ts` around lines 33 - 35, The Arabic
translation in the PolyForm Noncommercial License message in frontend_ar.ts
contains an extra phrase "أو إعادة التوزيع" (or redistribution) that does not
exist in the English source text. This adds an additional restriction that is
not present in the original license terms. Locate the Arabic translation entries
for the PolyForm Noncommercial License notice (appearing around lines 33-35 and
also at lines 213-215) and remove the phrase "أو إعادة التوزيع" from both
occurrences in the translation values to keep them faithful to the English
source text.

src/ui/translations/frontend_ja.ts (1)

213-214: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Keep the license notice aligned with the source text.

再配布 adds a redistribution restriction that the English source doesn’t mention, so the Japanese notice now states stricter terms than intended.

♻️ Proposed fix

-        <translation>この無料のソース公開ビルドは個人・非商用利用専用です。商用利用または再配布にはライセンスが必要です。</translation>
+        <translation>この無料のソース公開ビルドは個人・非商用利用専用です。商用利用には別途ライセンスが必要です。</translation>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/ui/translations/frontend_ja.ts` around lines 213 - 214, The Japanese
translation in the license notice at line 213-214 includes "または再配布" (or
redistribution) which is not present in the corresponding English source text,
creating an inconsistency where the Japanese version states stricter terms.
Remove the phrase "または再配布" from the translation so that only the commercial use
restriction remains, keeping the Japanese translation aligned with the English
source text about what requires a license.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@src/ui/translations/frontend_ar.ts`:
- Around line 33-35: The Arabic translation in the PolyForm Noncommercial
License message in frontend_ar.ts contains an extra phrase "أو إعادة التوزيع"
(or redistribution) that does not exist in the English source text. This adds an
additional restriction that is not present in the original license terms. Locate
the Arabic translation entries for the PolyForm Noncommercial License notice
(appearing around lines 33-35 and also at lines 213-215) and remove the phrase
"أو إعادة التوزيع" from both occurrences in the translation values to keep them
faithful to the English source text.

In `@src/ui/translations/frontend_ja.ts`:
- Around line 213-214: The Japanese translation in the license notice at line
213-214 includes "または再配布" (or redistribution) which is not present in the
corresponding English source text, creating an inconsistency where the Japanese
version states stricter terms. Remove the phrase "または再配布" from the translation
so that only the commercial use restriction remains, keeping the Japanese
translation aligned with the English source text about what requires a license.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 98af9cc1-3f6d-4996-9211-d3cbf5c10cb1

📥 Commits

Reviewing files that changed from the base of the PR and between ad63174 and 4a74864.

📒 Files selected for processing (32)

• rust/frontend/build.rs
• rust/frontend/src/lib.rs
• rust/frontend/src/mister_runtime.rs
• rust/frontend/src/models/crt_video.rs
• rust/frontend/src/models/mod.rs
• rust/frontend/src/models/settings.rs
• rust/zaparoo-core/src/config.rs
• rust/zaparoo-core/src/persist.rs
• src/app/main.cpp
• src/app/native_video_writer.cpp
• src/app/native_video_writer.h
• src/ui/app/Main.qml
• src/ui/app/MainLayout.qml
• src/ui/components/CMakeLists.txt
• src/ui/components/CrtCalibrationModal.qml
• src/ui/screens/SettingsScreen.qml
• src/ui/translations/frontend_ar.ts
• src/ui/translations/frontend_de.ts
• src/ui/translations/frontend_el.ts
• src/ui/translations/frontend_en.ts
• src/ui/translations/frontend_es.ts
• src/ui/translations/frontend_eu.ts
• src/ui/translations/frontend_he.ts
• src/ui/translations/frontend_hi.ts
• src/ui/translations/frontend_it.ts
• src/ui/translations/frontend_ja.ts
• src/ui/translations/frontend_ko.ts
• src/ui/translations/frontend_nl.ts
• src/ui/translations/frontend_ro.ts
• src/ui/translations/frontend_sk.ts
• src/ui/translations/frontend_uk.ts
• src/ui/translations/frontend_zh_CN.ts

💤 Files with no reviewable changes (2)

• src/ui/translations/frontend_zh_CN.ts
• src/ui/translations/frontend_uk.ts

✅ Files skipped from review due to trivial changes (2)

• src/ui/components/CMakeLists.txt
• rust/frontend/build.rs

🚧 Files skipped from review as they are similar to previous changes (14)

• rust/frontend/src/models/mod.rs
• src/ui/components/CrtCalibrationModal.qml
• rust/frontend/src/mister_runtime.rs
• rust/frontend/src/lib.rs
• rust/zaparoo-core/src/persist.rs
• rust/frontend/src/models/settings.rs
• rust/frontend/src/models/crt_video.rs
• src/app/main.cpp
• src/ui/app/MainLayout.qml
• src/app/native_video_writer.h
• src/app/native_video_writer.cpp
• src/ui/screens/SettingsScreen.qml
• src/ui/app/Main.qml
• rust/zaparoo-core/src/config.rs