Conversation
Move the CI matrix onto current GitHub-hosted runners: windows-2025, macos-15, ubuntu-26.04, with the compiler pins remapped to the new toolset (GCC 13 and 15, Clang 20 and 22), and bump checkout, upload-artifact, and gh-describe to current releases while fixing SC2035 glob quoting. The macOS builds get the dependencies and flags the local build needs: sdl2 (ZWidget's macOS backend is SDL2; without it the app fails to initialize), explicit Homebrew OpenAL include and library paths (the SDK OpenAL.framework is a broken symlink on current macOS), -DDYN_OPENAL=OFF, and -DCMAKE_BUILD_RPATH=/opt/homebrew/lib so ZMusic can dlopen libsndfile and libmpg123 at runtime. The Debug job drops -G Xcode so both macOS jobs use the Makefiles generator. The Create Package step drops the non-Release mv of gzdoom.app from a per-config subdirectory, a layout only the Xcode generator produces; with the Makefiles generator the app is already at the build root, so the mv failed the Debug packaging.
gretel
marked this pull request as ready for review
August 4, 2026 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the CI matrix to current GitHub-hosted runners and fix the macOS build and packaging so the artifacted app actually launches and has audio.
Changes
Runners and actions
windows-2025,macos-15, andubuntu-26.04, remapping the compiler pins to the toolchains those images ship (GCC 13/15, Clang 20/22).windows-2025toolchain (VS 2026 / MSVC 19.51).actions/checkout,actions/upload-artifact, andproudust/gh-describeto current releases./.macOS build fixes
sdl2: ZWidget's only non-Windows macOS backend is SDL2, so without it the built app fails at startup with "Unable to create init zwidget".OpenAL.frameworkis a broken symlink on current macOS, so the default search produces a build with no audio.libsndfileto the macOS brew dependencies.-DDYN_OPENAL=OFFand-DCMAKE_BUILD_RPATH=/opt/homebrew/libso ZMusic can dlopenlibsndfile/libmpg123at runtime — without the rpath, mod sounds decode to silence (sfx_empty).-G Xcodefrom the Debug job).Packaging
mvofgzdoom.appfrom a per-config subdirectory. That layout only exists with the Xcode generator; with Makefiles the app is already at the build root, which broke the Debug packaging step.Notes
proudust/gh-describe@v2.2.0targets Node 20 (deprecated; GitHub forces Node 24 with a warning). It is the action's latest release — flagging so it can be replaced or upstreamed.