test: bring public's suites and README up to the v0.87.0 plugin (ENG-1145) - #279
Conversation
…1145) A promotion replaces plugins/memhub/ only, so public's tests/ and README stayed at 0.76.1 while the plugin moved to 0.87.0. Six suites then failed guard and probe-tests on #278, each on an intentional internal change: the add_memory gate (22 hooks, #57), the companion skill (#47/#51), the author-child guard (#58), the one-line spec reminder (#61/#63), and the rulebook-verify and starter-rulebook wording/source_ref changes. The six suites are internal's at 711c0c1 (the promoted commit), with plugins/memhub-staging rewritten to plugins/memhub. The README gains the /memhub:companion entry and the seventeen-skill count the doc test pins. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H6kYog7yKLFVuXb12AAF2m
🧠 Session context1 session behind this pull request. Team rules that fired while building this
Effort Sessions
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 179a7ae88a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - `/memhub:companion [on | off | status]` — turns on the companion, the | ||
| pixel animal in the band above the prompt that sleeps while idle, watches | ||
| while Claude works, and stands up to announce a rule that fired. Enables | ||
| the function-hook runtime it needs and persists it; `/hippo` is the | ||
| animal's own command. |
There was a problem hiding this comment.
Mark companion availability as Claude Code-only
For Codex and Cursor installations, this newly listed feature is unavailable: plugins/memhub/skills/companion/SKILL.md explicitly says those hosts have no equivalent band and must stop. The root README is the multi-host command guide, so presenting /memhub:companion without that limitation leads users on those hosts to invoke a command that cannot provide the described functionality.
Useful? React with 👍 / 👎.
| for spelling in ("mcp__plugin_memhub_memhub__list_my_unlinked_prs", | ||
| "mcp__plugin_memhub_memhub__list_my_unlinked_prs"): |
There was a problem hiding this comment.
Check the staging list tool name in this assertion
This tuple repeats the production tool name, so the new test never verifies the distinct mcp__plugin_memhub-staging_memhub__list_my_unlinked_prs entry in the skill's frontmatter. If that staging permission is removed or renamed, staging users cannot list their unlinked PRs but this regression test still passes; make the second spelling the staging name.
Useful? React with 👍 / 👎.
Base is
promote/memhub-v0.87.0, notmain. Merge this into #278's branch so the plugin and the tests that describe it land together. Againstmain, the new tests would run against the 0.76.1 plugin and fail.Why #278 is red
A promotion replaces
plugins/memhub/and nothing else, so public'stests/and rootREADME.mdare still at 0.76.1.guardandprobe-testsrun those suites against the 0.87.0 plugin, and 6 of 73 fail.Production plugin readinessaggregatesprobe-tests, so it fails too.Each failure is an intentional internal change:
claude_hook_guard_testadd_memory_gate.py(internal #57)documentation_test/memhub:companionharness_stop_testspec_owns_port_test(+9 more)(internal #61/#63)rulebook_verify_teststarter_rulebook_testsource_ref=starter-rulebook@<ver>#idstarter-rulebook#id|catalog <ver>, a stable re-file keyInternal CI ran these same suites, in their current internal versions, against this exact code (
711c0c1) and passed.What
711c0c1, withplugins/memhub-stagingrewritten toplugins/memhub.README.md: the skill count goes from "Sixteen" to "Seventeen", and the/memhub:companionentry is added using internal's wording.Verified (locally, on this branch)
All exit 0: the six suites, plus
registration_test.pyandversion_parity_test.py. The other 67 suites already passed in #278's CI.🤖 Generated with Claude Code
https://claude.ai/code/session_01H6kYog7yKLFVuXb12AAF2m