Skip to content

test: bring public's suites and README up to the v0.87.0 plugin (ENG-1145) - #279

Merged
sgonz-xtrace merged 1 commit into
promote/memhub-v0.87.0from
tests/sync-memhub-v0.87.0
Sep 25, 2026
Merged

sgonz-xtrace merged 1 commit into
promote/memhub-v0.87.0from
tests/sync-memhub-v0.87.0

Conversation

@sgonz-xtrace

Copy link
Copy Markdown
Contributor

Base is promote/memhub-v0.87.0, not main. Merge this into #278's branch so the plugin and the tests that describe it land together. Against main, the new tests would run against the 0.76.1 plugin and fail.

Why #278 is red

A promotion replaces plugins/memhub/ and nothing else, so public's tests/ and root README.md are still at 0.76.1. guard and probe-tests run those suites against the 0.87.0 plugin, and 6 of 73 fail. Production plugin readiness aggregates probe-tests, so it fails too.

Each failure is an intentional internal change:

Suite Public (0.76.1) asserts 0.87.0 does, on purpose
claude_hook_guard_test 21 hook commands 22: + PreToolUse add_memory_gate.py (internal #57)
documentation_test 16 skills; no /memhub:companion 17 skills: the companion (internal #47/#51)
harness_stop_test an author pass runs its child an author child can never author (internal #58)
spec_owns_port_test all 12 stale specs on the line one line, (+9 more) (internal #61/#63)
rulebook_verify_test "generated" absent new wording for patterns with no literal
starter_rulebook_test source_ref = starter-rulebook@<ver>#id starter-rulebook#id|catalog <ver>, a stable re-file key

Internal CI ran these same suites, in their current internal versions, against this exact code (711c0c1) and passed.

What

  • The six suites are copied from internal at 711c0c1, with plugins/memhub-staging rewritten to plugins/memhub.
  • README.md: the skill count goes from "Sixteen" to "Seventeen", and the /memhub:companion entry is added using internal's wording.
  • No plugin files change.

Verified (locally, on this branch)

All exit 0: the six suites, plus registration_test.py and version_parity_test.py. The other 67 suites already passed in #278's CI.

🤖 Generated with Claude Code

https://claude.ai/code/session_01H6kYog7yKLFVuXb12AAF2m

…1145)

A promotion replaces plugins/memhub/ only, so public's tests/ and README
stayed at 0.76.1 while the plugin moved to 0.87.0. Six suites then failed
guard and probe-tests on #278, each on an intentional internal change:
the add_memory gate (22 hooks, #57), the companion skill (#47/#51), the
author-child guard (#58), the one-line spec reminder (#61/#63), and the
rulebook-verify and starter-rulebook wording/source_ref changes.

The six suites are internal's at 711c0c1 (the promoted commit), with
plugins/memhub-staging rewritten to plugins/memhub. The README gains the
/memhub:companion entry and the seventeen-skill count the doc test pins.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01H6kYog7yKLFVuXb12AAF2m
@xtrace-memhub-staging

xtrace-memhub-staging Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

🧠 Session context

1 session behind this pull request.

Team rules that fired while building this

  • tests-before-push (advise, 10×)
  • Delegate big file reads to a cheaper model (gate, 2×)
  • confirm-ambiguous-target (advise, 1×)
  • fetch-before-origin-read (advise, 1×)
  • missing-module-fresh-venv (advise, 1×)
  • no-stash-in-worktree (advise, 1×)
  • …more

Effort
1 session · 3h 11m agent time · 87.7M tokens · 581 turns

Sessions

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 179a7ae88a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread README.md
Comment on lines +371 to +375
- `/memhub:companion [on | off | status]` — turns on the companion, the
pixel animal in the band above the prompt that sleeps while idle, watches
while Claude works, and stands up to announce a rule that fired. Enables
the function-hook runtime it needs and persists it; `/hippo` is the
animal's own command.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Mark companion availability as Claude Code-only

For Codex and Cursor installations, this newly listed feature is unavailable: plugins/memhub/skills/companion/SKILL.md explicitly says those hosts have no equivalent band and must stop. The root README is the multi-host command guide, so presenting /memhub:companion without that limitation leads users on those hosts to invoke a command that cannot provide the described functionality.

Useful? React with 👍 / 👎.

Comment on lines +139 to +140
for spelling in ("mcp__plugin_memhub_memhub__list_my_unlinked_prs",
"mcp__plugin_memhub_memhub__list_my_unlinked_prs"):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Check the staging list tool name in this assertion

This tuple repeats the production tool name, so the new test never verifies the distinct mcp__plugin_memhub-staging_memhub__list_my_unlinked_prs entry in the skill's frontmatter. If that staging permission is removed or renamed, staging users cannot list their unlinked PRs but this regression test still passes; make the second spelling the staging name.

Useful? React with 👍 / 👎.

@sgonz-xtrace
sgonz-xtrace merged commit f5b1edd into promote/memhub-v0.87.0 Sep 25, 2026
1 check passed
@sgonz-xtrace
sgonz-xtrace deleted the tests/sync-memhub-v0.87.0 branch September 25, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant