Repository navigation
feat(ui): enable plugin editor providers on the page editor (WI-1787) - #445
Merged
Merged
Conversation
Swap the page body editor to PluginEditorHost with editorProviders=true, the second surface after the item description. The native editor is unchanged when no provider is installed.
|
Size Change: 0 B 🆕 Total Size: 0 B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #444. Swaps the knowledge-page body editor (
PageEditor.svelte) toPluginEditorHostwitheditorProviders={true}, the second surface after the item description.The native Milkdown editor is unchanged when no provider is installed; the toggle only appears when an enabled+licensed plugin declares an
editor.markdownprovider forpage.Verification
bun run check,svelte-check— pass../core-testsfrontend suite: all files pass exceptchatStore.svelte.test.js, which fails only because the shared core-tests checkout carries another session's uncommitted chat test expecting an uncommitted core change; it passes againstmainand is unrelated to this swap. No page-editor unit tests exist to regress.Part of WI-1787. The plugin itself ships from a separate repository.