test: isolate typeof fixture checks from query setup - #68
Merged
Merged
Conversation
Load the shipped grammar and compile configured queries once before the three independent fixture checks. Keep each fixture's five-second deadline and all existing public-tree, capture and incremental edit assertions. Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Intel post-merge job at 112bb86 timed out the existing typeof test twice: 10.9s initially and 7.1s on its single failed-job retry against a 5s deadline. One test currently includes loading the grammar, compiling three queries and checking three independent fixtures. Local actual API measurements assign about 169ms of 202ms to initialization, with fixture checks around 22ms, 5ms and 6ms. The CI log cannot attribute the remote time to a specific stage; the setup-heavy lifecycle is established locally, while runner contention remains a hypothesis.
Requirements
Customer Summary
Keep the typeof compatibility and edit checks reliable on slower runners, with a distinct failure for each fixture.
Technical Summary
Move real Wasm/query initialization into a setup hook with the existing query-compilation test's 30s budget. Run the three unchanged fixture bodies as separate tests, each with its own parser/trees and the default 5s deadline. The hook owns the shared read-only queries and releases them after the suite. Grammar, generated parser, Wasm, runtime, dependencies and the error-recovery CPU assertion are unchanged.
Testing
The entire original fixture body, including all domain assertions, actual edits, fresh-tree comparisons, restoration and tree cleanup, is byte-exact. Fresh generation/build passes and eleven production/config/performance sources plus rebuilt Wasm are unchanged. Lint/types and the typeof/conversion/definition/query checks pass four files/15 tests in 4.8s. After integrating merged PR #67, lint/types and the typeof/operator checks also pass two files/four tests in 2.1s. All current-head CI checks pass. Readiness
1791271189-2787e01b8585b312reports PASS at5b6a653f79b95c24bd2339a049de05c20f5b8bf9with no new conversation events. Review0b8feadfcompleted with that same last-reviewed/completion head, reviewed by successful exploration sessions: five successes, two unavailable Claude routes, no findings. All three saved notes and seven job contexts were inspected; one reviewer could not run the test without an unbuilt Wasm, while author and CI checks cover execution. No provider retry or new retrospective issue was warranted.Notes
This is a separate test-lifecycle follow-up to merged PR #66. Published C++ 1.5.5 passed official package, native, browser, Cargo and corpus retention checks; its post-merge Intel job remains failed. No further rerun of that source or relaxed performance assertion is used. Local timing is not a general performance guarantee.