Init submodules when fetching extensions and skins - #7
Open
claude[bot] wants to merge 1 commit into
Open
claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
Wikibase keeps view/lib/wikibase-termbox and four other view libraries as git submodules. fetch-repos.py cloned and reset without them, so every tree built by init-version.sh had those directories empty and TermboxModule::readJsonFile fataled on the missing resources.json while building the startup ResourceLoader module. Matches what mw-deploy's shim already does (mwdeploy_shim.py:543,796). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MuStKvs3pWiFUNmf615dgN
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested via Slack thread
Before:
fetch-repos.pycloned withgit clone --depth=1 --branch <REL>and updated withfetch/checkout/reset --hard. Neither touched submodules. Wikibase declares five of them in.gitmodules, includingview/lib/wikibase-termbox(gerritwikibase/termbox), so every treeinit-version.shbuilds left those directories empty.After: the clone recurses submodules and the update path runs
git submodule update --init --recursive, soview/lib/wikibase-termbox/resources.jsonand the other view libraries are present. The update path also repairs trees an earlier run left empty.resources.jsonis a committed file in the termbox submodule, not a build artifact —TermboxModule::getMessages()reads it while ResourceLoader assembles thestartupmodule, so a missing one throwsRuntimeException: Failed to open …/resources.jsonand that request gets no JS module registry at all (MEDIAWIKI-CS1).How
Two flags, mirroring what
mw-deploy's shim already does for the same trees (shim/mwdeploy_shim.py:543,:796) — the two tools disagreed and only the scaffold was wrong.Validated locally against a throwaway superproject holding a
view/lib/wikibase-termboxsubmodule:python3 -m py_compile scripts/extensions/fetch-repos.pyresources.jsonpresent--recurse-submodules) reproduces the empty directory;fetch-repos.py --updateover it restores the fileThis is a latent defect fix, not a proven cause of the single-host event on
mw-us-east-011— only that one node of four is affected, which points at that host's synced tree rather than at the scaffold. The ops repair there is still needed.🤖 Generated with Claude Code
https://claude.ai/code/session_01MuStKvs3pWiFUNmf615dgN
Generated by Claude Code