Skip to content

Point extensions/OOJSPlus at the real OOJSPlus repository - #3

Open
claude[bot] wants to merge 1 commit into
mainfrom
sentry/oojsplus-manifest-url
Open

claude[bot] wants to merge 1 commit into
mainfrom
sentry/oojsplus-manifest-url

Conversation

@claude

@claude claude Bot commented Sep 10, 2026

Copy link
Copy Markdown

Requested by Thomas · Slack thread

Before: In both scripts/extensions/repos-1.45.yaml and scripts/extensions/repos-1.46.yaml, the entry for path: extensions/OOJSPlus points at https://github.com/hallowelt/mwstake-mediawiki-component-commonuserinterface on branch: master. That is a different component entirely — it is a Composer-loaded mwstake component that ships bootstrap.php and no extension.json — so the farm has been deploying the wrong code into the extensions/OOJSPlus directory. The visible symptom is Sentry MEDIAWIKI-2J4 (83,641 events): SimpleBlogPage's blog list calls OOJSPlus.ui.data.grid.Paginator.prototype.init(), which is not there. Special:Blogs renders an empty widget, and because the error is thrown inside a jQuery .done() handler, no failure path runs either — there is no error message for readers, just a blank list.

After: Both manifests point extensions/OOJSPlus at https://github.com/wikimedia/mediawiki-extensions-OOJSPlus with branch: _version_, so each version tree checks out its matching release branch (REL1_45 for the 1.45 manifest, REL1_46 for the 1.46 one) instead of a fixed master. That is the actual OOJSPlus extension, and its release branches carry the Paginator.prototype.init that SimpleBlogPage calls.

How: Four lines changed, two per file — the url and branch keys of the extensions/OOJSPlus entry only. Nothing else in either manifest is touched. _version_ matches the convention used by the neighbouring Wikimedia entries and is expanded by fetch-repos.py from the manifest filename.

What was verified, and what was not. Verified from here: git ls-remote https://github.com/wikimedia/mediawiki-extensions-OOJSPlus resolves and has both refs/heads/REL1_45 and refs/heads/REL1_46 — this matters because a missing branch makes fetch-repos.py exit non-zero, and init-version.sh runs under set -euo pipefail, so a bad branch name would abort the whole version build. Both of those branches contain an extension.json at the repo root, and REL1_45 contains OOJSPlus.ui.data.grid.Paginator.prototype.init in resources/ui/data/grid/Paginator.js (it is absent on that repo's master, which is consistent with the reported breakage pattern). The old URL's master tree was listed and confirmed to have no extension.json. Both edited files parse cleanly under yaml.safe_load.

Not verified: this was not run against a real MediaWiki tree. No checkout, no init-version.sh run, and no page load of Special:Blogs — so the claim that this clears MEDIAWIKI-2J4 is reasoning from the manifest and the upstream source, not an end-to-end test. Worth a staging build to confirm OOJSPlus registers and the blog list paginates before this reaches production.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AiEBkhzV1z9bEykvEU9U8j


Generated by Claude Code

The OOJSPlus entry in repos-1.45.yaml and repos-1.46.yaml pointed at
hallowelt/mwstake-mediawiki-component-commonuserinterface on master.
That is a different component: it ships bootstrap.php and no
extension.json, so extensions/OOJSPlus was never OOJSPlus at all.

Point both manifests at wikimedia/mediawiki-extensions-OOJSPlus and use
the _version_ token so each version tree tracks its matching release
branch (REL1_45 / REL1_46), both of which exist upstream and carry an
extension.json.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AiEBkhzV1z9bEykvEU9U8j
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2f1ba4c5-3b93-4102-9f76-6e2b1bb916c3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant