Point extensions/OOJSPlus at the real OOJSPlus repository - #3
Open
claude[bot] wants to merge 1 commit into
Open
claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
The OOJSPlus entry in repos-1.45.yaml and repos-1.46.yaml pointed at hallowelt/mwstake-mediawiki-component-commonuserinterface on master. That is a different component: it ships bootstrap.php and no extension.json, so extensions/OOJSPlus was never OOJSPlus at all. Point both manifests at wikimedia/mediawiki-extensions-OOJSPlus and use the _version_ token so each version tree tracks its matching release branch (REL1_45 / REL1_46), both of which exist upstream and carry an extension.json. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AiEBkhzV1z9bEykvEU9U8j
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Thomas · Slack thread
Before: In both
scripts/extensions/repos-1.45.yamlandscripts/extensions/repos-1.46.yaml, the entry forpath: extensions/OOJSPluspoints athttps://github.com/hallowelt/mwstake-mediawiki-component-commonuserinterfaceonbranch: master. That is a different component entirely — it is a Composer-loaded mwstake component that shipsbootstrap.phpand noextension.json— so the farm has been deploying the wrong code into theextensions/OOJSPlusdirectory. The visible symptom is SentryMEDIAWIKI-2J4(83,641 events): SimpleBlogPage's blog list callsOOJSPlus.ui.data.grid.Paginator.prototype.init(), which is not there.Special:Blogsrenders an empty widget, and because the error is thrown inside a jQuery.done()handler, no failure path runs either — there is no error message for readers, just a blank list.After: Both manifests point
extensions/OOJSPlusathttps://github.com/wikimedia/mediawiki-extensions-OOJSPluswithbranch: _version_, so each version tree checks out its matching release branch (REL1_45for the 1.45 manifest,REL1_46for the 1.46 one) instead of a fixedmaster. That is the actual OOJSPlus extension, and its release branches carry thePaginator.prototype.initthat SimpleBlogPage calls.How: Four lines changed, two per file — the
urlandbranchkeys of theextensions/OOJSPlusentry only. Nothing else in either manifest is touched._version_matches the convention used by the neighbouring Wikimedia entries and is expanded byfetch-repos.pyfrom the manifest filename.What was verified, and what was not. Verified from here:
git ls-remote https://github.com/wikimedia/mediawiki-extensions-OOJSPlusresolves and has bothrefs/heads/REL1_45andrefs/heads/REL1_46— this matters because a missing branch makesfetch-repos.pyexit non-zero, andinit-version.shruns underset -euo pipefail, so a bad branch name would abort the whole version build. Both of those branches contain anextension.jsonat the repo root, andREL1_45containsOOJSPlus.ui.data.grid.Paginator.prototype.initinresources/ui/data/grid/Paginator.js(it is absent on that repo'smaster, which is consistent with the reported breakage pattern). The old URL'smastertree was listed and confirmed to have noextension.json. Both edited files parse cleanly underyaml.safe_load.Not verified: this was not run against a real MediaWiki tree. No checkout, no
init-version.shrun, and no page load ofSpecial:Blogs— so the claim that this clearsMEDIAWIKI-2J4is reasoning from the manifest and the upstream source, not an end-to-end test. Worth a staging build to confirm OOJSPlus registers and the blog list paginates before this reaches production.🤖 Generated with Claude Code
https://claude.ai/code/session_01AiEBkhzV1z9bEykvEU9U8j
Generated by Claude Code