Skip to content

refactor(CRater): Remove idea names from rubric and detected ideas display - #2372

Merged
breity merged 2 commits into
developfrom
crater-remove-idea-names-display
Nov 3, 2026
Merged

breity merged 2 commits into
developfrom
crater-remove-idea-names-display

Conversation

@breity

@breity breity commented Nov 3, 2026

Copy link
Copy Markdown
Member

Changes

  • CRaterRubricComponent: Remove the ID (idea.name) column from the rubric table. The table now shows only the Description column.
  • DetectedIdeasComponent: Remove the bold idea.name. prefix and the name !== text check. Each detected idea now shows only its text.
  • Add unit tests in both component specs that check the idea text is displayed.

Test

As a teacher in the Teacher Tools, open steps in Grade By Step view that contain Open Response and Dialog Guidance components with CRater ideas.

  • In student work with detected ideas, click the rubric button to open the Idea Detection Rubric dialog. Ensure that:
    • The table has only a Description column, with no ID column.
    • Idea rows are still colored if the rubric has idea colors.
  • Look at the "Ideas detected:" box. Ensure that:
    • Each idea shows only its text, with no ID prefix such as 1..
    • Idea chips are still colored if the rubric has idea colors.

As a student in a run, navigate to a step that has a Dialog Guidance Show My Work component with additionalSettings.showDetectedIdeas set to true. Ensure that detected ideas show only the idea text, with no ID prefix.

@breity breity self-assigned this Nov 3, 2026
@qltysh

qltysh Bot commented Nov 3, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@breity
breity merged commit 86b4517 into develop Nov 3, 2026
4 checks passed
@breity
breity deleted the crater-remove-idea-names-display branch November 3, 2026 07:42
@hirokiterashima

Copy link
Copy Markdown
Member

🎉 This PR is included in version 5.251.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants