Repository navigation
feat(CRaterRubric): add authoring and display of idea sample responses - #2371
Merged
Merged
Conversation
❌ 1 blocking issue (1 total)
|
| text?: string, | ||
| tags?: string[], | ||
| color?: string, | ||
| sampleResponses?: string[] |
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (5)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
- Update rubric table to a single Ideas column and place sample responses below idea text - Add toggle link in table header to show/hide sample responses (hidden by default) - Support keyboard activation (Enter/Space) and role="button" for toggle link - Update unit tests in crater-rubric.component.spec.ts
Member
|
🎉 This PR is included in version 5.251.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes
sampleResponsestoCRaterIdeaandIdeaData.hasSampleResponsestoCRaterRubric, set totruewhen any idea in the rubric has at least one non-empty sample response.EditCRaterIdeaDescriptionsComponentto allow authors to add, edit, and delete sample responses for each idea, and to initialize sample response inputs when importing a rubric viaCRaterItemSelectComponent.CRaterRubricComponentto display ideas and their sample responses in a single column ("Ideas"), with sample responses rendered directly beneath the idea text.CRaterRubricComponenttable header when sample responses are present (hidden by default), with accessible keyboard support (EnterandSpace).CRaterRubric.spec.ts,crater-rubric.component.spec.ts, andedit-crater-idea-descriptions.component.spec.ts.Test
c-rater-item-selectto import a rubric and verify that each imported idea displays aSample Responseinput field (or multiple fields if the imported rubric already contains sample responses).Sample Responseinput field.+button, verify that the labels update toSample Response #1,Sample Response #2, etc., and verify that thexdelete button removes a sample response after confirmation.Ideascolumn and no toggle button appears in the header.Ideascolumn and shows a "Show sample responses" button in the header row.Enter/Spacewhile focused) and verify non-empty sample responses appear indented under their respective idea texts.