Repository navigation
Conversation
Opening a step in Grade by Step makes both the response list and the question summary call retrieveStudentDataForNode for the same node, so every revision of the step's work was downloaded twice in parallel. The list stays empty until the download ends, and for steps with a lot of work that response is large. Concurrent requests with identical parameters now share one download. A call made after the first request has finished or failed requests again, so nothing is cached beyond the request in flight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a step in Grade by Step makes both the response list and the question summaries call
retrieveStudentDataForNodefor the same node, so the step's work was downloaded twice in parallel. The response holds every revision of every team's work; for a concept map step in a class of 125 teams it was 57 MB, and the two parallel downloads took over three minutes, during which the list stayed empty.Concurrent requests with identical parameters now share one download. A call made after the first request has finished or failed requests again, so nothing is cached beyond the request in flight. Both callers ignore the emitted value and read the data from the service, which now processes the response once instead of twice.
Testing: new
teacherDataService.spec.tswith four tests. The sharing test fails on develop; the other three (different nodes, a later call, a call after a failure) guard against caching too much and were checked against deliberately broken variants. Full suite: 2503 pass, with one failure that also fails on develop.