Repository navigation
Clone VFB_neo4j from master instead of the neo4-2 branch - #68
Merged
Merged
Conversation
The neo4-2 branch was last updated in October 2021 and is 366 commits behind master, with no commits of its own - it is a pure ancestor, so this is a catch-up rather than a switch to a divergent line. Two concrete problems with staying on neo4-2: - Its neo4j_connect.__init__ probes the Neo4j v3 endpoint first with no Content-type header, which a v4+ server answers with 415 Unsupported Media Type. Every connection therefore logs a spurious 415 before falling back to v4. Master probes v4 first. - Its commit_list has no retry logic at all, so any transient non-200 (e.g. a 502 from the gateway) or dropped connection fails the query outright. Master retries with exponential backoff. Together these took down the scheduled Create Reports run on 2026-09-19 and 2026-09-22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
neo4-2branch was last updated in October 2021 and is 366 commits behindmaster, with no commits of its own — it's a pure ancestor, so this is a catch-up rather than a switch to a divergent line.Two concrete problems with staying on
neo4-2:neo4j_connect.__init__probes the Neo4j v3 endpoint first with noContent-typeheader, which a v4+ server answers with415 Unsupported Media Type. Every connection therefore logs a spurious415before falling back to v4.masterprobes v4 first.commit_listhas no retry logic at all, so any transient non-200 (e.g. a502from the gateway) or dropped connection fails the query outright.masterretries with exponential backoff.Together these took down the scheduled
Create Reportsrun on 2026-09-19 and 2026-09-22.