Repository navigation
Add /reports/<id> viewer URLs to the term sitemap alongside static pages - #505
Merged
Merged
Conversation
The static term pages at /term/<slug>/ carry sitemap_exclude: true because Hugo's own sitemap.xml has no pagination -- a sharded sitemap-terms.xml index (sitemap1.xml..) is written separately for them, advertised in robots.txt. That shard writer now lives in vfbterms.py itself rather than an undocumented external step: after every group is processed it emits sitemap1.xml.. plus the sitemap-terms.xml index, listing both the static page and the /reports/<id> viewer URL (now indexable per the geppetto-vfb SEO fix) for every term. Output directory is an optional 3rd CLI argument -- point it at wherever Jenkins publishes static files from (e.g. the Hugo public/ directory) to wire it into the live site; omit it and nothing changes from today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static term pages at /term// carry sitemap_exclude: true because
Hugo's own sitemap.xml has no pagination -- a sharded sitemap-terms.xml
index (sitemap1.xml..) is written separately for them and advertised in
robots.txt. That shard writer now lives in vfbterms.py itself: after
every group is processed it writes sitemap1.xml.. plus the
sitemap-terms.xml index, listing both the static page and the
/reports/ viewer URL (now indexable, per the recent geppetto-vfb
Soft-404 fix) for every term.
Output directory is an optional 3rd CLI argument, and should be /src/public
-- the same directory deploy.sh builds Hugo into (RancherServices'
hugo-builder service, workspace update_vfb_static_site), which
vfb-static-site serves straight from:
Omit the argument and nothing changes from today -- the call in
test_vfbterms.yml is unaffected. Wiring this in is a one-line change to
the Jenkins job's vfbterms.py invocation; nothing else currently writes
sitemap1.xml/sitemap-terms.xml as far as I can find, so this replaces
that step rather than racing it.