feat: add boundary for dashboard - #5815
cuzz-venus wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: d535f39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR adds reusable section-level error containment and applies it to route content, dashboard sections, and area charts. It also makes account-performance chart formatting tolerate omitted API points and adds localized retry text.
Confidence Score: 4/5The PR should not merge until route navigation clears a previously tripped layout boundary and the explicit component-organization rule is satisfied. A page render failure can leave the persistent layout boundary latched across navigation, causing otherwise healthy destination pages to remain hidden; the AreaChart refactor also violates an explicit repository structure requirement. Files Needing Attention: apps/evm/src/containers/Layout/index.tsx; apps/evm/src/components/AreaChart/index.tsx; apps/evm/src/components/SectionErrorBoundary/tests/index.spec.tsx Important Files Changed
Reviews (1): Last reviewed commit: "feat: add boundary for dashboard" | Re-trigger Greptile |
| <SectionErrorBoundary className="my-20"> | ||
| <Outlet /> | ||
| </SectionErrorBoundary> |
There was a problem hiding this comment.
Error persists across navigation
Layout remains mounted when users navigate between sibling routes. If one page throws, this boundary stays in its error state and hides the destination page until the user clicks Retry or reloads. Reset the boundary when the route changes so a failure on one page does not block another page.
| <SectionErrorBoundary className="my-20"> | |
| <Outlet /> | |
| </SectionErrorBoundary> | |
| <SectionErrorBoundary key={pathname} className="my-20"> | |
| <Outlet /> | |
| </SectionErrorBoundary> |
Knowledge Base Used: Application shell and routing
Coverage Report for ./apps/evm
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Jira ticket(s)
VPD-XXX
Changes