chore: add code complexity checks to CI - #561
Merged
Merged
Conversation
GitGuru7
marked this pull request as ready for review
September 21, 2026 12:19
|
promise, import, node and prettier were never listed in .eslintrc plugins or extended, so none of their rules ran. Prettier still runs via its own CLI and eslint-config-prettier stays.
GitGuru7
force-pushed
the
feat/code-complexity-gates
branch
from
September 22, 2026 08:04
a86990d to
ff66bbe
Compare
|
fred-venus
approved these changes
Sep 22, 2026
Debugger022
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the TypeScript complexity gates stricter and adds a local formatting helper.
What changed
^8.25.0), pluseslint-plugin-promise→^6.1.1whose peer range was ESLint 7 only. This is a prerequisite:eslint-plugin-sonarjs@1.0.4cannot run on ESLint 7.complexityandsonarjs/cognitive-complexitynow error at 15eslint-plugin-sonarjs(^1.0.4)prettier:cachedscript for local use — CI'sprettier:checkis unchanged.solhint.jsonwas left alone —code-complexityis already 15.Suppressed
One test helper, left with an ignore comment:
deployVTokenDependenciesintests/hardhat/util/TokenTestHelpers.ts— complexity 21, cognitive complexity 20Refactored
deploy/009-deploy-vtokens.ts— the three-way interest-rate-model chain moved intodeployInterestRateModel, and the ProtocolShareReserve try/catch intoresolveProtocolShareReserve. Order of operations, arguments and throws are unchanged.getConfiginhelpers/deploymentConfig.ts(complexity 19) — an 18-case switch became a keyed lookup.Verified
The ESLint 8 bump produced no new findings on its own — same warning count as before.
yarn lint:tsandyarn lint:solboth pass with no errors.