Skip to content

Bugfix: improved check_deltakpoly in sicdcheck - #176

Merged
pressler-vsc merged 1 commit into
mainfrom
bugfix/sicdcheck-check_deltakpoly
Oct 5, 2026
Merged

pressler-vsc merged 1 commit into
mainfrom
bugfix/sicdcheck-check_deltakpoly

Conversation

@pressler-vsc

Copy link
Copy Markdown
Contributor

Description

This PR:

  • improves the method for determining the expected DeltaKs in sicdcheck's check_deltakpoly
    • currently, only the ValidData vertices are used (or FullImage corners if missing). In addition to being rather sparse, these are possibly outside of the extent of the SICD in question
    • this branch proposes an adapted version of the method recently added to sarkit-processing
  • improves the docstrings/messages and downgrades the check from need -> want
    • because the standard doesn't explicitly prescribe how these should be filled out; I believe want is more appropriate

@pressler-vsc
pressler-vsc merged commit 81336ef into main Oct 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants