fix zero-length nanoids and update pgrx to 0.19.2 - #185
Merged
t3hmrman merged 1 commit intoSep 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
idkit_nanoid_custom_generate_text(0, 'abc')enters a non-terminating loop in nanoid 0.4.0. Return an empty string when the normalized length is zero, preserving the existing negative-length clamp and positive-length generation. Add regression tests for zero, -1, andi64::MIN.Fixes #184
This change is based on current upstream
main(3183860) and preserves its dependency and CI action updates. The lockfile resolvesuuidto 1.26.0 because pgrx 0.19.2 requires^1.23.2; this remains within the project's existing^1.20requirement. The upstreamgetrandom0.4.1 and recentanyhow,chrono,time, andkeccakupdates are retained.The pgrx migration also:
pgrxand the existingpgrx-testsdependency to=0.19.2, refreshing their runtime and test dependency graph without adding a direct runtime dependency.pgrx_embedbinary declaration and source file, which use a macro removed from current pgrx.Validation on Rocky Linux 9.8, aarch64, PostgreSQL 17.11, Rust 1.98.0, and cargo-pgrx 0.19.2:
The MSRV toolchain, other PG/OS combinations, and upstream CI were not run in this validation.