Repository navigation
feat: add delegated credential account controls - #2325
Open
donmasakayan wants to merge 4 commits into
Open
donmasakayan wants to merge 4 commits into
donmasakayan wants to merge 4 commits into
Conversation
This was referenced Oct 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2324 — review only the top commit (0903a69)
Summary
Add toolkit and connection selection, one-time key and external-proof handoff, rotation, revocation, verified-target administration, notifications, and audit review to account settings. Keep proof material in dialog-local memory and preserve explicit empty-connection denial.
This targets v2 following the backlog invitation to resubmit, after the prior closed #1610/#1948.
Verification
All verification below was run locally from the final frozen stack; no public CI run is claimed.
bun run format:check— 2,226 files, exit 0.bun run lint— 1,933 files, zero warnings or errors, including the changeset stub check.bun run typecheck— 45/45 tasks, exit 0.bun run test— 39/39 workspace tasks; 4,633 tests passed, 45 conditional skips, zero failures.delegated-credentials-a-member-key-keeps-an-approved-emulator-connection-scoped-anddelegated-credentials-selfhost-issues-masks-and-revokes-a-local-keyexercised key creation, proof completion, final consent, scoped emulator invocation, and UI revocation; 2 applicable cases passed with issuance enabled and the default issuance-disabled case also passed. Local trace-redaction coverage passed 3/3. Recordings and traces are retained locally and are not publicly linked.Live IdP and Cloudflare Access login flows were not exercised; coverage for those flows is limited to unit/integration tests.
Checklist
Stack