Repository navigation
Conversation
Add a resultType discriminator to TravelAuctionResult, mirroring AuctionResult, and require type on the hotels and flights requests. Both describe current auction-engine behavior: a missing or unknown type is rejected, and resultType echoes the request type. Clears the four Redocly no-illogical-composition-keywords errors on main. INTE-1541 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
anonvt
enabled auto-merge (squash)
October 13, 2026 19:22
Contributor
Author
|
Closing as a duplicate of #207, which fixes the same Redocly findings more thoroughly (own hotels result schema, constrained resultType, empty result dropped from the travel oneOf). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the four
no-illogical-composition-keywordsRedocly errors that have failed the lint check onmainand on every PR since the travel schemas landed. Spec-only; no change to auction-engine or central-services. Ticket: INTE-1541.Changes (
topsort-api-v2.yml)TravelAuctionResult: add aresultTypediscriminator mappinghotels,flightsandemptyto their result schemas, mirroring the existingAuctionResultblock, which passes the same rule for the same reason.HotelsAuctionRequest/FlightsAuctionRequest: addtypetorequired.Why this matches the engine
getTravelAdTypereturns an error for anytypeother thanhotelsorflights, so a missingtypeis already rejected. Requiring it in the spec describes current behavior.api_travel_auctions.gosetsresultTypeto the request'stype, so the discriminator values are what the engine returns today.Validation
redocly lint --extends recommended-strictis clean for the first time ("Your API description is valid").prettier --check,yamllint,typosandvacuum lint(0 errors) pass.🤖 Generated with Claude Code