Skip to content

chore: add vendor id to auction winner responses #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LemonPy29 merged 1 commit into from
Oct 5, 2026
Merged

chore: add vendor id to auction winner responses #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions topsort-api-v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1291,7 +1291,7 @@
- $ref: "#/components/schemas/EmptyAuctionResult"
TravelAuctionResult:
description: The result of a travel-related auction request (hotels or flights).
oneOf:

Check failure on line 1294 in topsort-api-v2.yml

View workflow job for this annotation

GitHub Actions / Redocly

no-illogical-composition-keywords 

Schemas in `oneOf` must be mutually exclusive. Found overlapping schemas: `#/components/schemas/FlightsAuctionResult` and `#/components/schemas/EmptyAuctionResult`. Both schemas define `resultType`, `error` without constraints that exclude each other. Add a discriminator, or constrain the shared properties to different values.

Check failure on line 1294 in topsort-api-v2.yml

View workflow job for this annotation

GitHub Actions / Redocly

no-illogical-composition-keywords 

Schemas in `oneOf` must be mutually exclusive. Found overlapping schemas: `#/components/schemas/HotelsAuctionResult` and `#/components/schemas/EmptyAuctionResult`. Both schemas define `resultType`, `error` without constraints that exclude each other. Add a discriminator, or constrain the shared properties to different values.

Check failure on line 1294 in topsort-api-v2.yml

View workflow job for this annotation

GitHub Actions / Redocly

no-illogical-composition-keywords 

Schemas in `oneOf` must be mutually exclusive. Found overlapping schemas: `#/components/schemas/HotelsAuctionResult` and `#/components/schemas/FlightsAuctionResult`. Both schemas define `resultType`, `error` without constraints that exclude each other. Add a discriminator, or constrain the shared properties to different values.
- $ref: "#/components/schemas/HotelsAuctionResult"
- $ref: "#/components/schemas/FlightsAuctionResult"
- $ref: "#/components/schemas/EmptyAuctionResult"
Expand Down Expand Up @@ -1418,6 +1418,9 @@
$ref: "#/components/schemas/ResolvedBidID"
campaignId:
$ref: "#/components/schemas/CampaignId"
vendorId:
$ref: "#/components/schemas/ExternalVendorId"
description: The ID of the vendor associated with the winning campaign.
ExternalDemandSponsoredListingsWinner:
type: object
required:
Expand Down Expand Up @@ -1495,6 +1498,9 @@
$ref: "#/components/schemas/ResolvedBidID"
campaignId:
$ref: "#/components/schemas/CampaignId"
vendorId:
$ref: "#/components/schemas/ExternalVendorId"
description: The ID of the vendor associated with the winning campaign.
asset:
description: The list of available sources for a banner.
type: array
Expand Down Expand Up @@ -1556,6 +1562,9 @@
variationID:
type: string
description: The marketplace's ID for the winning flight's variation.
vendorId:
$ref: "#/components/schemas/ExternalVendorId"
description: The ID of the vendor associated with the winning campaign.
RankingResult:
description: The result of a ranking request, containing ordered products.
type: object
Expand Down Expand Up @@ -1953,7 +1962,7 @@
$ref: "#/components/schemas/SponsoredBrandContent"
TravelAuctionRequest:
description: Describes the intent of running a single auction.
oneOf:

Check failure on line 1965 in topsort-api-v2.yml

View workflow job for this annotation

GitHub Actions / Redocly

no-illogical-composition-keywords 

Schemas in `oneOf` must be mutually exclusive. Found overlapping schemas: `#/components/schemas/HotelsAuctionRequest` and `#/components/schemas/FlightsAuctionRequest`. Add `type` to `required` in every schema; an optional property cannot distinguish the schemas.
- $ref: "#/components/schemas/HotelsAuctionRequest"
- $ref: "#/components/schemas/FlightsAuctionRequest"
HotelsAuctionRequest:
Expand Down
Loading