Repository navigation
Conversation
Adds Menu Position X and Menu Position Y sliders to Misc Settings, right under Right Align Menu. The middle of the slider is the default position. MenuAPI draws the menu with NUI and Menu.Position doesn't do anything, so the offset is sent to index.html which moves #menuapi and clamps it to the screen after every draw, so the menu can't be moved off screen. Saved right away like Right Align Menu.
Collaborator
|
No further changes will be made to the old vMenu at this point. Closing this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Menu Position X and Menu Position Y sliders to Misc Settings, under Right Align Menu. The middle of the slider is the default position.
Menu.Positiondoesn't do anything since MenuAPI moved to NUI, so the client sends the offset toindex.htmland the page moves#menuapiitself. After every draw it also clamps the menu to the screen, so you can't push it off screen no matter the resolution or how tall the current menu is. Works with Right Align Menu too.Saved right away like Right Align Menu, no need to hit save preferences.