Repository navigation
chore(deps): bump scipy to >=1.17.1 - #382
Merged
Merged
Conversation
scipy 1.17+ does not support Python 3.10; raise the project floor and refresh the lockfile. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Published documentation remains inconsistent with Python 3.11+, and the stated Python 3.12 SciPy resolution differs from the lockfile.
2 open findings
What changed in this PR
Raises the minimum supported Python and SciPy versions and aligns CI and installation guidance.
Changes:
- Requires Python 3.11+ and SciPy 1.17.1+.
- Removes Python 3.10 from CI and package classifiers.
- Refreshes dependency resolution and README guidance.
| File | Description |
|---|---|
README.md |
Updates Python installation requirements. |
pyproject.toml |
Raises Python/SciPy constraints and classifiers. |
.github/workflows/ci.yaml |
Removes Python 3.10 from CI. |
uv.lock |
Refreshes resolved dependencies. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Use environment markers so 3.10 stays on scipy<=1.15.3 while newer interpreters resolve scipy 1.17+. Co-authored-by: Cursor <cursoragent@cursor.com>
utilsforecast rejects 0 in `level`; use decile-style levels in tests and example notebooks. Co-authored-by: Cursor <cursoragent@cursor.com>
Align with quantile interpolation and TimesFM level support; fixes level forecast tests on CI with foundationforecast 0.1.8. Co-authored-by: Cursor <cursoragent@cursor.com>
TimeCopilot stats/ML wrappers inherit cross_validation from FoundationForecast but often skip base __init__; default exog_strategy=False and ensure state before CV. Align TimeCopilotForecaster.cross_validation signature with futr_exog_list. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep cross_validation exog_strategy guard only; explicit __init__ broke call-arg typing for multiply-inherited foundation wrappers in mypy. Co-authored-by: Cursor <cursoragent@cursor.com>
FoundationForecast>=0.1.12 rejects level 0; use [20, 80] instead of [0, 80]. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scipy>=1.17.1(lock: 1.17.1 on 3.11, 1.18.1 on 3.12+).scipy<=1.15.3(SciPy 1.17+ has no 3.10 wheels).uv.lock; Python 3.10 support unchanged (requires-python >=3.10).Local check
uv run pre-commit run --all-files— passedpytest tests/models/test_models.py::test_using_level[model24] -n 0(Tafsut) — passed on 3.11Test plan