Repository navigation
Fix CAS ticket validation in Cloudflare Workers - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deployed CAS callback returned 502 because Cloudflare Workers rejects
fetchwithredirect: "error"before making a request. Node's fetch accepts this value, so the unit tests did not catch the runtime difference.Use
redirect: "manual"and reject non-2xx responses, preserving the requirement that validation never follows redirects. Add a redirect-response regression case.Validation: all 30 auth tests and TypeScript pass. The bundled auth handler was also exercised in the actual Workers runtime with Miniflare: live Princeton CAS rejects an invalid ticket as expected, a mocked successful CAS response creates a readable signed session, and a mocked redirect is rejected without being followed. CI runs the production build.