Replace Entra sign-in with Princeton CAS - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PI now signs students in through Princeton CAS and uses the validated CAS NetID for chat ownership. This removes the Entra client secret requirement and the OIT email-alias lookup.
Validation: 29 auth tests pass, TypeScript passes, and the production build passes. Princeton's live CAS endpoint returns the expected JSON rejection for an invalid ticket, and its login page accepts PI's callback URL with state. A complete student login still requires a Princeton account.
Deployment uses the existing SESSION_SECRET; CAS needs no application client secret. Existing NetID-owned chats retain their namespaces. Historical email-alias namespaces are not automatically reassigned.