Repository navigation
fix(deps): move zip to a patched release - #22
Open
TheStreamCode wants to merge 2 commits into
Open
TheStreamCode wants to merge 2 commits into
TheStreamCode wants to merge 2 commits into
Conversation
The workspace and two crates pinned zip 3, and office_oxide pulled zip 8.6.0 through pdf_oxide. Every open advisory, including the critical parser differential in 9.0.4 and earlier, is fixed in 9.0.5. Bump the workspace and crate pins to zip 9, update office_oxide to 0.1.16 so the transitive copy resolves to the same major, and adapt the two API changes: file_names and entry name now return a Result. The extraction guard keeps validating the raw entry name, because enclosed_name normalizes . components away. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The 3 to 9 migration closes RUSTSEC-2026-0367, -0368, -0369 and -0429, so their ignores are stale. RUSTSEC-2026-0441 (pin-utils unmaintained) arrives transitively through aws-smithy-http and has no released replacement. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close all six open
zipadvisories, including the critical parser differential that allows arbitrary file overwrite.Two vulnerable copies were in the tree: the direct pin at 3.0.0 (workspace,
chutes-tools,chutes-update) and 8.6.0 pulled in byoffice_oxidethroughpdf_oxide.zip = "9".office_oxide0.1.9 to 0.1.16, which requireszip ^9.1, so a single patched copy resolves (9.1.2).zip9:file_names()andZipFile::name()now return aResult.extract_zipkeeps validating the raw entry name, becauseenclosed_name()now normalizes.components away and would otherwise accept./cmd/git.exe.Verification
cargo check -p chutes-tools -p chutes-update: cleancargo test -p chutes-update --lib: 139 passed, 0 failed, including the three archive-extraction guardscargo test -p chutes-tools --lib pptx: 8 passed, 0 failedrustfmt --checkon both changed filescargo-denyadvisories job should now passNotes
cargo test -p chutes-update --test test_networkreports 4 failures in thegcs_pointer_*tests on this machine. Those tests exercise the GCS pointer retry policy, not archive extraction; the lockfile diff touches only the zip/office_oxide chain, and the same tests pass onmainin CI. CI on this pull request is the authoritative check.