Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix unbounded zip decompression memory exhaustion - #328

Open
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
sentinel-cap-zip-decompression-2743301280253101284
Open

google-labs-jules[bot] wants to merge 1 commit into
mainfrom
sentinel-cap-zip-decompression-2743301280253101284

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ›‘οΈ Sentinel: [HIGH] Fix unbounded zip decompression memory exhaustion (Zip Bomb DoS)

  • 🚨 Severity: HIGH
  • πŸ’‘ Vulnerability: When reading info.json from mod zip archives in mod_store.rs and downloader.rs, entry.read_to_string() performed unbounded decompression into memory. A malicious or malformed zip entry claiming to be info.json could decompress gigabytes into RAM, triggering an Out-Of-Memory (OOM) denial-of-service crash.
  • 🎯 Impact: Application crash or system memory exhaustion when scanning untrusted mod zips or verifying downloads.
  • πŸ”§ Fix: Bound decompressed entry reads to a maximum of 10 MB (MAX_INFO_JSON_BYTES) using .take(MAX_INFO_JSON_BYTES) prior to reading to string.
  • βœ… Verification: Unit test test_read_info_json_caps_stream_read added; full backend test suite (cargo test) and frontend typecheck/build (pnpm build) pass.

PR created automatically by Jules for task 2743301280253101284 started by @TheDragonSoft

Bound decompression reads of info.json entries from mod archives
to a maximum of 10 MB to prevent Zip Bomb / memory exhaustion DoS.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants