Repository navigation
π‘οΈ Sentinel: [HIGH] Fix unbounded zip decompression memory exhaustion - #328
google-labs-jules[bot] wants to merge 1 commit into
Conversation
Bound decompression reads of info.json entries from mod archives to a maximum of 10 MB to prevent Zip Bomb / memory exhaustion DoS.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘οΈ Sentinel: [HIGH] Fix unbounded zip decompression memory exhaustion (Zip Bomb DoS)
info.jsonfrom mod zip archives inmod_store.rsanddownloader.rs,entry.read_to_string()performed unbounded decompression into memory. A malicious or malformed zip entry claiming to beinfo.jsoncould decompress gigabytes into RAM, triggering an Out-Of-Memory (OOM) denial-of-service crash.MAX_INFO_JSON_BYTES) using.take(MAX_INFO_JSON_BYTES)prior to reading to string.test_read_info_json_caps_stream_readadded; full backend test suite (cargo test) and frontend typecheck/build (pnpm build) pass.PR created automatically by Jules for task 2743301280253101284 started by @TheDragonSoft