Skip to content

🎨 Palette: Accessible Downloads Queue Drawer with Escape dismissal & focus restoration - #327

Open
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
palette/accessible-queue-drawer-13973563186546495252
Open

google-labs-jules[bot] wants to merge 1 commit into
mainfrom
palette/accessible-queue-drawer-13973563186546495252

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

🎨 Palette UX Improvement: Accessible Downloads Queue Drawer

💡 What:

Enhanced QueueDrawer with proper dialog semantics, Escape key dismissal, and keyboard focus restoration:

  • Integrated QueueDrawer with overlayStack (pushOverlay / popOverlay) to close when the Escape key is pressed if it's the topmost overlay.
  • Captured previously focused element on drawer open and restored focus to it on drawer close.
  • Added role="dialog", aria-modal={isOpen}, and aria-label="Downloads".
  • Added aria-hidden={!isOpen} and inert={!isOpen ? true : undefined} to ensure assistive tech and keyboard navigation skip offscreen drawer content when closed.

🎯 Why:

Previously, the QueueDrawer stayed mounted off-screen when closed, allowing keyboard navigation to tab into hidden interactive elements. Additionally, pressing Escape did not dismiss the drawer, and closing it did not return focus to the triggering button.

♿ Accessibility:

  • Full screen reader dialog announcement and labeling (role="dialog", aria-label="Downloads").
  • Keyboard accessibility: Escape dismisses the drawer, focus is smoothly returned to the trigger, and closed off-screen states are inert.

PR created automatically by Jules for task 13973563186546495252 started by @TheDragonSoft

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants