Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Mitigate zip bomb DoS in mod archive inspection - #326

Open
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
sentinel/cap-zip-decompression-4827880971884044475
Open

google-labs-jules[bot] wants to merge 1 commit into
mainfrom
sentinel/cap-zip-decompression-4827880971884044475

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Unbounded decompression stream when reading info.json from untrusted mod archives (entry.read_to_string(&mut s)) in mod_store::read_info_json and downloader::verify_mod_zip_sync.
🎯 Impact: A malicious zip bomb or heavily padded entry could exhaust system memory during library scan or download verification, causing application crash (Denial of Service).
πŸ”§ Fix: Wrapped the decompressed entry reader with .take(MAX_INFO_JSON_BYTES) (2 MiB limit) before reading into a string, added unit tests verifying that oversized archives are capped and rejected cleanly, and documented security learnings in .jules/sentinel.md.
βœ… Verification: Ran cargo test --manifest-path src-tauri/Cargo.toml (all 142 tests passing) and pnpm build.


PR created automatically by Jules for task 4827880971884044475 started by @TheDragonSoft

Cap decompressed reads of info.json to 2 MiB across mod_store
and downloader to prevent out-of-memory denial of service.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants