Repository navigation
⚡ Bolt: reuse Intl.Collator instances for installed mods sorting - #324
google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced repeated calls to
String.prototype.localeComparewith options inside the sorting comparator inInstalledPage.tsxwith module-level pre-instantiatedIntl.Collatorinstances (collatorBaseandcollatorExact).🎯 Why: In JavaScript runtimes (V8/WebView2), calling$O(N \log N)$ allocations per sort). During list re-sorts (such as mod status updates or folder rescans with hundreds of mods), this incurs substantial CPU overhead and garbage collection pressure.
String.prototype.localeComparewith options initializes anIntl.Collatorinstance on every comparison (📊 Impact: Reduces sorting time by ~50x in benchmarks (e.g. from ~30ms down to ~0.6ms on 500 items over 100 iterations) and eliminates thousands of short-lived
Intl.Collatorallocations.🔬 Measurement: Benchmarked with Node/V8 comparing
localeCompare(..., { sensitivity: 'base' })vs module-levelIntl.Collator.prototype.compare. Exact sorting equality confirmed. Frontend builds cleanly viapnpm build.PR created automatically by Jules for task 4405256087993414310 started by @TheDragonSoft