Skip to content

🎨 Palette: enhance QueueDrawer accessibility and keyboard dismiss - #321

Open
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
palette-queue-drawer-a11y-1267154972449575190
Open

google-labs-jules[bot] wants to merge 1 commit into
mainfrom
palette-queue-drawer-a11y-1267154972449575190

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

💡 What

Enhanced the downloads QueueDrawer slide-over panel with modal accessibility semantics, keyboard interaction, and focus management:

  • Registered with overlayStack (pushOverlay/popOverlay/isTopOverlay) so pressing the Escape key closes the drawer without conflicting with other overlays.
  • Captured previously focused element when opened, focused the drawer, and restored focus to the triggering element upon close.
  • Added role="dialog", aria-modal="true", aria-label="Downloads", aria-hidden={!isOpen}, and inert={!isOpen ? true : undefined} to prevent off-screen focus leaks.

🎯 Why

Previously, the downloads slide-over drawer could only be closed by clicking the close button or backdrop. It could not be dismissed via Escape, lacked ARIA dialog attributes for assistive technology, and when closed remained off-screen in the DOM without inert/aria-hidden.

♿ Accessibility

  • Full screen reader dialog announcements via role="dialog", aria-modal="true", and aria-label="Downloads".
  • Offscreen elements are ignored by keyboard navigation and assistive technology via aria-hidden and inert.
  • Predictable focus management upon opening and closing.

PR created automatically by Jules for task 1267154972449575190 started by @TheDragonSoft

Add accessible dialog semantics, focus management, and Escape key dismissal to QueueDrawer.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants