Repository navigation
🎨 Palette: enhance QueueDrawer accessibility and keyboard dismiss - #321
google-labs-jules[bot] wants to merge 1 commit into
Conversation
Add accessible dialog semantics, focus management, and Escape key dismissal to QueueDrawer.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Enhanced the downloads
QueueDrawerslide-over panel with modal accessibility semantics, keyboard interaction, and focus management:overlayStack(pushOverlay/popOverlay/isTopOverlay) so pressing theEscapekey closes the drawer without conflicting with other overlays.role="dialog",aria-modal="true",aria-label="Downloads",aria-hidden={!isOpen}, andinert={!isOpen ? true : undefined}to prevent off-screen focus leaks.🎯 Why
Previously, the downloads slide-over drawer could only be closed by clicking the close button or backdrop. It could not be dismissed via
Escape, lacked ARIA dialog attributes for assistive technology, and when closed remained off-screen in the DOM withoutinert/aria-hidden.♿ Accessibility
role="dialog",aria-modal="true", andaria-label="Downloads".aria-hiddenandinert.PR created automatically by Jules for task 1267154972449575190 started by @TheDragonSoft