Skip to content

🎨 Palette: Make QueueDrawer an accessible modal drawer with Escape dismissal and focus management - #313

Open
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
palette/queue-drawer-a11y-escape-8968970561943105050
Open

google-labs-jules[bot] wants to merge 1 commit into
mainfrom
palette/queue-drawer-a11y-escape-8968970561943105050

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

💡 What

Enhanced QueueDrawer with proper dialog semantics, focus management, and Escape key dismissal through Axial's overlayStack.

🎯 Why

Previously, the QueueDrawer did not support dismissing via the standard Escape key and remained accessible to screen readers and keyboard navigation even when closed offscreen (translate-x-full).

♿ Accessibility

  • Added role="dialog", aria-modal="true", and aria-label="Downloads".
  • Set aria-hidden={!isOpen} and inert={!isOpen ? true : undefined} so offscreen drawer elements are ignored by screen readers and tab navigation when closed.
  • Registered with overlayStack (pushOverlay/popOverlay/isTopOverlay) so pressing Escape closes the topmost overlay layer.
  • Added focus management: automatically focuses the drawer panel on open and restores previous focus to the triggering element on close.

PR created automatically by Jules for task 8968970561943105050 started by @TheDragonSoft

…Drawer

Register QueueDrawer with overlayStack to allow closing via Escape,
manage focus on open/close, and add proper ARIA dialog and inert attributes.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants