Repository navigation
🎨 Palette: Improve QueueDrawer accessibility and keyboard navigation - #309
google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Enhanced the
QueueDrawercomponent to improve accessibility and keyboard navigation:role="dialog",aria-modal="true", andaria-label="Downloads queue"to provide clear dialog semantics for assistive technologies.aria-hidden={!isOpen}andinert={!isOpen ? true : undefined}to prevent keyboard navigation and screen readers from accessing the drawer when closed offscreen.overlayStack(pushOverlay,popOverlay,isTopOverlay) to support closing the drawer with theEscapekey in the proper stack order.🎯 Why
The downloads drawer is rendered permanently in the DOM and slides on/off screen. Previously, it lacked dialog accessibility semantics, allowed focus to enter the drawer while hidden offscreen, and could not be dismissed via the standard
Escapekeyboard shortcut.♿ Accessibility
Escape.role="dialog",aria-modal="true",aria-label).inertandaria-hidden.PR created automatically by Jules for task 16341381551340021411 started by @TheDragonSoft