Skip to content

πŸ›‘οΈ Sentinel: cap archive info.json decompression size to prevent zip bomb DoS - #304

Open
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
sentinel/fix-zip-bomb-dos-2316590505834879537
Open

google-labs-jules[bot] wants to merge 1 commit into
mainfrom
sentinel/fix-zip-bomb-dos-2316590505834879537

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ›‘οΈ Sentinel Security Report

  • 🚨 Severity: MEDIUM (Denial of Service / Resource Exhaustion)
  • πŸ’‘ Vulnerability: Unbounded stream decompression when reading info.json archive entries from mod zip files (entry.read_to_string(&mut s)).
  • 🎯 Impact: An untrusted or maliciously crafted mod zip (hosted on a mirror or placed in the mods directory) containing a zip bomb could decompress gigabytes of repetitive data into memory, causing an Out-Of-Memory (OOM) process crash and denial of service for the desktop application.
  • πŸ”§ Fix: Defined MAX_INFO_JSON_BYTES (2 MiB) in mod_store.rs. Capped decompression stream reads in both mod_store::read_info_json and downloader::verify_mod_zip_sync using .take(MAX_INFO_JSON_BYTES + 1), rejecting entries exceeding the limit with an explicit error.
  • βœ… Verification:
    • Added unit test in mod_store verifying rejection of oversized/zip-bomb info.json entries without OOM.
    • Added unit test in downloader verifying rejection of oversized/zip-bomb info.json entries during download verification.
    • Executed all 143 cargo tests (cargo test --manifest-path src-tauri/Cargo.toml) and verified frontend build (pnpm build).
    • Documented learnings in .jules/sentinel.md.

PR created automatically by Jules for task 2316590505834879537 started by @TheDragonSoft

…ip bombs

Limit decompression reads of untrusted mod archive metadata entries
(info.json) to MAX_INFO_JSON_BYTES (2 MiB) in mod_store and downloader.
Prevents unbounded heap allocation and Out-Of-Memory (OOM) Denial of
Service when parsing maliciously crafted mod zips.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants