Repository navigation
π‘οΈ Sentinel: cap archive info.json decompression size to prevent zip bomb DoS - #304
google-labs-jules[bot] wants to merge 1 commit into
Conversation
β¦ip bombs Limit decompression reads of untrusted mod archive metadata entries (info.json) to MAX_INFO_JSON_BYTES (2 MiB) in mod_store and downloader. Prevents unbounded heap allocation and Out-Of-Memory (OOM) Denial of Service when parsing maliciously crafted mod zips.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘οΈ Sentinel Security Report
info.jsonarchive entries from mod zip files (entry.read_to_string(&mut s)).MAX_INFO_JSON_BYTES(2 MiB) inmod_store.rs. Capped decompression stream reads in bothmod_store::read_info_jsonanddownloader::verify_mod_zip_syncusing.take(MAX_INFO_JSON_BYTES + 1), rejecting entries exceeding the limit with an explicit error.mod_storeverifying rejection of oversized/zip-bombinfo.jsonentries without OOM.downloaderverifying rejection of oversized/zip-bombinfo.jsonentries during download verification.cargo test --manifest-path src-tauri/Cargo.toml) and verified frontend build (pnpm build)..jules/sentinel.md.PR created automatically by Jules for task 2316590505834879537 started by @TheDragonSoft