Skip to content

Upgrade ruff in pre-commit - #14982

Merged
cclauss merged 5 commits into
TheAlgorithms:masterfrom
hojen2:fix-lbp-except-syntax
Jul 31, 2026
Merged

Upgrade ruff in pre-commit#14982
cclauss merged 5 commits into
TheAlgorithms:masterfrom
hojen2:fix-lbp-except-syntax

Conversation

@hojen2

@hojen2 hojen2 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Describe your change:

Fixed a bug in local_binary_pattern.py. Currently, the code uses old Python 2 syntax except IndexError, TypeError:, which isn't valid in Python 3 and caused the file to fail before it could run.

Fixed it by adding parentheses: except (IndexError, TypeError):.

Confirmed the fix by running the file through Python's compiler and mypy, both passed with no errors.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Jul 31, 2026
@cclauss
cclauss self-requested a review as a code owner July 31, 2026 15:30
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Jul 31, 2026
@cclauss cclauss changed the title Fix invalid Python 2 syntax in except clause Upgrade ruff in pre-commit Jul 31, 2026
@cclauss
cclauss merged commit 758d487 into TheAlgorithms:master Jul 31, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants