Skip to content

Remove country flags from language selector - #502

Merged
Eldemarkki merged 1 commit into
Testaustime:mainfrom
bluelhf:patch-1
Dec 21, 2025
Merged

Eldemarkki merged 1 commit into
Testaustime:mainfrom
bluelhf:patch-1

Conversation

@bluelhf

@bluelhf bluelhf commented Dec 21, 2025

Copy link
Copy Markdown
Contributor

Flags do not correspond to languages and will cause problems with internationalisation if new languages are ever added. For example, Bengali is spoken widely in both India and Bangladesh.

fixes #501

Flags do not correspond to languages and will cause problems with internationalisation if new languages are ever added.
@vercel

vercel Bot commented Dec 21, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
testaustime Ready Ready Preview, Comment Dec 21, 2025 1:49pm
testaustime-storybook Ready Ready Preview, Comment Dec 21, 2025 1:49pm

@Eldemarkki

Copy link
Copy Markdown
Member

Fair, I had a bit of trouble choosing the flag for English :D Thanks for the PR!

@Eldemarkki
Eldemarkki merged commit 5a29dcd into Testaustime:main Dec 21, 2025
7 checks passed
@bluelhf
bluelhf deleted the patch-1 branch December 21, 2025 14:25

This branch was successfully deployed

2 active deployments
Preview – testaustime-storybook — e1976034 Deployed Dec 21, 2025 by vercel[bot]
Preview – testaustime — e1976034 Deployed Dec 21, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Best practice: do not use country flags to represent languages

2 participants