fix(energy): don't let a None owned key clobber cloud in merge_local_into_cloud - #149
Merged
Conversation
…_local_into_cloud PowerwallEnergySite.live_status() returns None for keys the gateway can't serve; the presence-only overlay check was letting that None win over a good cloud value. Claude-Session: https://claude.ai/code/session_01NJqvy4EqPJQwZbb2SGEHLh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the presence-only overlay in
merge_local_into_cloud(tesla_fleet_api/router/energysite.py):PowerwallEnergySite.live_status()returns all cloud keys withNonefor ones the gateway can't serve, so an owned key present withNonewas overwriting a good cloud value. Now overlays only when the key is owned, present, and notNone; falsy-but-real values (0,False,"") still overlay.🤖 Generated with Claude Code
https://claude.ai/code/session_01NJqvy4EqPJQwZbb2SGEHLh