ci: fail the tap token before notarize - #7
Merged
Conversation
The tap is public, so an unset HOMEBREW_TAP_TOKEN clones anonymously and only dies at git push — after the GitHub release and appcast.xml are already published. Probe emptiness, credentials, and push access before Build, sign, notarize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tap is public, so
git clonewith an emptyHOMEBREW_TAP_TOKENsucceeds anonymously. The job then published the GitHub release andappcast.xmlbefore dying atgit pushon the cask.This adds a preflight after Resolve version (before importing the Developer ID cert):
SPARKLE_PRIVATE_KEY)git ls-remoteso an expired/invalid token fails immediatelygh api … .permissions.pushso a read-only token fails too (ls-remotecannot see write scope on a public repo)Do not tag
v0.1.0until this is onmain.