fix: keep Sparkle off the cold-start URL path - #6
Merged
Conversation
makeUpdater ran as an AppDelegate stored-property initializer, so SecStaticCodeCheckValidity hashed the bundle (including Sparkle) before the first open URL was dispatched. Construct the updater on the next main-actor turn after launch, and skip sealed-resource hashing; the Developer ID requirement still rejects ad-hoc builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makeUpdater()ran as an AppDelegate stored-property initializer, soSecStaticCodeCheckValidityhashed the whole bundle (including Sparkle.framework) before a cold-start URL open was dispatched.applicationDidFinishLaunching, once the status item exists.AppServices.updaterstays the no-op until then.kSecCSDoNotValidateResources. The Developer ID requirement (team 92X3ACDPD2, leaf OID 6.1.13) still fails ad-hoc and Apple Development.This should land before the first
v*tag.