fix: keep Sparkle off ad-hoc make install builds - #3
Merged
Conversation
Baking the real EdDSA key made shouldEnable true for every .app that isn't in Caskroom. A make install copy would auto-check and try to replace itself once v0.1.0 publishes an appcast item. Require a Developer ID Application signature from team 92X3ACDPD2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Baking the real EdDSA key made
shouldEnabletrue for every.appthat is not in Caskroom. Amake installcopy would auto-check and try to replace itself once v0.1.0 publishes an appcast item.Sparkle now also requires a Developer ID Application signature from team 92X3ACDPD2 (
SecStaticCodeCheckValidity). Ad-hoc and Apple Development stay onDisabledUpdater. Homebrew (Caskroom) is still skipped.Verified the same requirement with
codesign -R:/Applications/Browseroute.app(ad-hoc) fails; TickerBar and yap pass.This should land before the first
v*tag.