feat: bake a Sparkle EdDSA key and write appcast on release - #2
Merged
Conversation
GitHub zip installs could never self-update: SUPublicEDKey was a placeholder and the release job never published appcast.xml. Mint a Browseroute-only key, bake the public half, and sign/commit the appcast the same way TickerBar does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub zip installs could never self-update:
SUPublicEDKeywas a placeholder and the release job never publishedappcast.xml.SPARKLE_PRIVATE_KEY.appcast.xmltomainthe same way TickerBar does.sparkle:versionis the app'sCFBundleVersion(git commit count), which Sparkle actually compares.Homebrew cask installs still skip Sparkle (
Caskroompath). This must land before the firstv*tag.Not in this PR: Developer ID p12 /
DEV_ID_P12_PASSWORD/NOTARY_ISSUER_ID/HOMEBREW_TAP_TOKEN— av*tag would still fail notarization and the tap update until those are copied from TickerBar.