fix: sign Sparkle's Autoupdate so notarization passes - #10
Merged
Conversation
Apple rejected v0.1.0 with three errors, both architectures, all on Sparkle.framework/Versions/B/Autoupdate: not signed with a valid Developer ID certificate, no secure timestamp, no hardened runtime. Autoupdate is a bare Mach-O, so it matched neither *.xpc nor *.app and the inside-out loop skipped it, leaving the ad-hoc signature that package_app.sh applies. Sign bare Mach-O helpers beside the bundles, pruning nested bundles whose executables are signed with their bundle. notarytool also exits 0 on an Invalid submission, so the script walked on to stapler and died with "Record not found", which says nothing about the cause. Read the status and print the notary log instead. Verified: every Mach-O in the bundle now reports team 92X3ACDPD2, flags=0x10000(runtime) and a timestamp, and the real notary service returns Accepted in 23s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.1.0notarization came backInvalid. Apple's log, both architectures, all on one path:Autoupdateis a bare Mach-O executable, so it matched neither*.xpcnor*.appand the inside-out loop skipped it. It kept the ad-hoc signaturepackage_app.shapplies for dev launches. Now bare Mach-O helpers beside the nested bundles are signed too; nested bundles are pruned because their main executables get signed with their bundle, and the framework's ownSparklebinary is signed with the framework.Second bug, same class as the
find-identityone:notarytool submit --waitexits 0 even when the submission isInvalid, so the script continued into stapler and failed there withRecord not found— an error that says nothing about the cause. It now reads the status and dumps the notary log on anything other thanAccepted.Verified locally against the real notary service, not just inspection: