Skip to content

Improve update status check for stable version comparisons #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DarkSpirit006 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve update status check for stable version comparisons #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76c06b7
fix: improve update status check for stable versions
DarkSpirit006 Aug 5, 2026
d2eeee8
fix: correct comparison of build versions in update status check
DarkSpirit006 Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/main/java/net/skullian/updater/Updater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ public static UpdateStatus checkUpdate(CommandSender... senders) {
try {
if (currentBuild.stable()) {
latestBuild = GithubUtils.lookupLatestRelease();
lookupStatus = GithubUtils.compare(latestBuild.id(), currentBuild.id());
if (isSameStableVersion(currentBuild, latestBuild)) {
updateStatus.setUpToDate(true);
return updateStatus;
}
lookupStatus = GithubUtils.compare(latestBuild.name(), currentBuild.name());
} else {
latestBuild = null;
lookupStatus = GithubUtils.compare(GithubUtils.MAIN_BRANCH, currentBuild.id());
Expand All @@ -50,6 +54,10 @@ public static UpdateStatus checkUpdate(CommandSender... senders) {
return updateStatus;
}

private static boolean isSameStableVersion(GithubBuildInfo currentBuild, GithubBuildInfo latestBuild) {
return currentBuild.name().equals(latestBuild.name()) || currentBuild.id().equals(latestBuild.id());
}

@AllArgsConstructor
@Getter
@Setter
Expand Down