Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrettyTables 3 renamed the table-header keyword from
headertocolumn_labels, so widening the existing compat bound alone makesshow(::Samples)fail with aMethodError. Select the keyword from the loaded PrettyTables major version and retain PrettyTables 2 support.The new display test checks the observable sample type, labels, and values. Focused
test/sampling.jlruns pass with both PrettyTables 2.4.0 and 3.4.8 on Julia 1.12.4 after rebasing onto the merged sampling and MMAP changes. Each run passes the 5 display assertions, 2 probabilistic-model sampling checks, the MPS sampling check, and the rescaled-array sampling check.Dependency ordering blocker: registered ProblemReductions 0.3.5 still restricts PrettyTables to version 2, so a registry-only environment cannot currently select PrettyTables 3 with TensorInference. This PR must wait for a ProblemReductions release containing its already-merged PrettyTables 2/3 compatibility update; current CI resolves PrettyTables 2 and does not clear that blocker.