fix(env): PHP 8.2 deprecated ${var} string interpolation in is_staging() - #24
Merged
Conversation
"is_${key}_staging" uses dollar-brace interpolation, deprecated in
PHP 8.2 and removed in PHP 9 (fatal parse error). Every plugin
bundling the framework logs a deprecation on each is_staging() call
on PHP 8.2+. Only occurrence in the repo.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012z98xz1AJ4XFZeQSghhk9v
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
env/index.php:42 builds the staging-check function name with
"is_${key}_staging". The${var}interpolation form was deprecated in PHP 8.2 (RFC) and is removed in PHP 9, where this becomes a fatal parse error.Because the framework is vendored into every plugin on the stack, each of them currently emits
Deprecated: Using ${var} in strings is deprecatedon everyis_staging()call under PHP 8.2+ — and all of them break together on PHP 9.Two-character fix:
${key}→{$key}. Behavior is identical (verified the built string matches). This is the only${occurrence in the repo.Found while adopting design-upgrade-pro-learndash onto the Tangible stack; it was previously noted in the tangible-solulu knowledge base as "documented but not yet filed."
🤖 Generated with Claude Code
https://claude.ai/code/session_012z98xz1AJ4XFZeQSghhk9v